You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/20 09:13:48 UTC
[GitHub] [incubator-dolphinscheduler-website] break60 opened a new pull request #278: Optimize the developer module
break60 opened a new pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] break60 commented on pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#issuecomment-763472477
> It's also necessary to search the old refer link and repalce them by new link globally, such as the keyword `docs/development`
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on a change in pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on a change in pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#discussion_r560812084
##########
File path: src/pages/development/index.md.jsx
##########
@@ -0,0 +1,42 @@
+import React from 'react';
+import ReactDOM from 'react-dom';
+import Language from '../../components/language';
+import Header from '../../components/header';
+import Footer from '../../components/footer';
+import Md2Html from '../../components/md2html';
+import Bar from '../../components/bar';
+import Sidemenu from '../../components/sidemenu';
+import developmentConfig from '../../../site_config/development';
+
+class Development extends Md2Html(Language) {
+ render() {
+ const language = this.getLanguage();
+ let dataSource = developmentConfig[language];
+ const __html = this.props.__html || this.state.__html;
+ return (
+ <div className="md2html development-page">
+ <Header
+ currentKey="development"
+ type="normal"
+ logo="/img/hlogo_colorful.svg"
+ language={language}
+ onLanguageChange={this.onLanguageChange}
+ />
+ <Bar img="/img/system/docs.png" text={dataSource.barText} />
Review comment:
Is it necessary to change to a new picture?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] break60 commented on pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#issuecomment-763510342
> It's better to execute `npm run lint:fix`~
already fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#issuecomment-764202679
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#issuecomment-763475334
It's better to execute `npm run lint:fix`~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] chengshiwen commented on pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278#issuecomment-764202679
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] xingchun-chen merged pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
xingchun-chen merged pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] xingchun-chen merged pull request #278: Optimize the developer module
Posted by GitBox <gi...@apache.org>.
xingchun-chen merged pull request #278:
URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org