You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 23:39:35 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #20089: Simplify helm install command in chart index

jedcunningham commented on a change in pull request #20089:
URL: https://github.com/apache/airflow/pull/20089#discussion_r763497370



##########
File path: docs/helm-chart/index.rst
##########
@@ -86,9 +86,8 @@ To install this chart using Helm 3, run the following commands:
 
 .. code-block:: bash
 
-    kubectl create namespace airflow
     helm repo add apache-airflow https://airflow.apache.org
-    helm install airflow apache-airflow/airflow --namespace airflow
+    helm upgrade airflow apache-airflow/airflow --namespace airflow --create-namespace --install

Review comment:
       ```suggestion
       helm upgrade --install airflow apache-airflow/airflow --namespace airflow --create-namespace
   ```
   
   nit, maybe it's my muscle memory, but tossing `--install` right after `upgrade` makes it more clear to me its "upgrade or install"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org