[GitHub] [helix] alirezazamani commented on a change in pull request #1231: Terminal State Job Purging

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r467312466



##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -147,10 +147,17 @@
     StartTime,
 
     /**
-     * The expiration time for the job
+     * The expiration time for the job if it's completed; once the expiry is reached and the job is
+     * completed, the job will be purged
      */
     Expiry,
 
+    /**
+     * The expiration time for the job if it's failed or timed out; once the expiry is reached and
+     * the job has failed or timed out, the job will be purged
+     */
+    TerminalStateExpiry,

Review comment:
       I think it makes more sense to keep this config in the as job config because we are treating this config similar to Expiry. If anybody want to use it, they can add this config.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org