You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/01 20:32:36 UTC
[jclouds-labs-google] Reduce or eliminate custom json type adapter
code (#72)
Less work needed with https://github.com/jclouds/jclouds/pull/596 in
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.no-more-namingpolicy
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/72
-- Commit Summary --
* JCLOUDS-750 Remove need for custom json type adapters on OAuth.
* JCLOUDS-750 adjust for changes in @SerializedNames contract.
-- File Changes --
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageParserModule.java (7)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/BucketAccessControls.java (10)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPage.java (8)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineParserModule.java (51)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ProjectApiExpectTest.java (1)
M oauth/src/main/java/org/jclouds/oauth/v2/OAuthApiMetadata.java (4)
D oauth/src/main/java/org/jclouds/oauth/v2/config/OAuthParserModule.java (159)
D oauth/src/main/java/org/jclouds/oauth/v2/domain/ClaimSet.java (42)
R oauth/src/main/java/org/jclouds/oauth/v2/domain/Claims.java (22)
M oauth/src/main/java/org/jclouds/oauth/v2/domain/Header.java (3)
M oauth/src/main/java/org/jclouds/oauth/v2/domain/Token.java (6)
M oauth/src/main/java/org/jclouds/oauth/v2/domain/TokenRequest.java (8)
M oauth/src/main/java/org/jclouds/oauth/v2/functions/BuildTokenRequest.java (19)
M oauth/src/test/java/org/jclouds/oauth/v2/binders/OAuthTokenBinderTest.java (14)
M oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiLiveTest.java (14)
M oauth/src/test/java/org/jclouds/oauth/v2/features/OAuthApiMockTest.java (15)
M oauth/src/test/java/org/jclouds/oauth/v2/internal/BaseOAuthAuthenticatedApiLiveTest.java (15)
M oauth/src/test/java/org/jclouds/oauth/v2/parse/ParseTokenTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/72.patch
https://github.com/jclouds/jclouds-labs-google/pull/72.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Adrian Cole <no...@github.com>.
@ccustine @andreaturli @nacx
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61380187
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #217](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/217/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61660088
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #203](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/203/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61380298
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Adrian Cole <no...@github.com>.
> @@ -92,18 +88,15 @@ public Long get() {
> // fetch the token
> Header header = Header.create(signatureAlgorithm, "JWT");
>
> - Map<String, String> claims = new LinkedHashMap<String, String>();
> + Map<String, Object> claims = new LinkedHashMap<String, Object>();
> claims.put("iss", credentialsSupplier.get().identity);
much more work needed here, and elsewhere in oauth, but will follow-up later.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72/files#r19707177
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Adrian Cole <no...@github.com>.
google storage tests are missing testName annotation attributes. This is likely behind the flakey test. Since almost all tests are still using expect tests, let's fix that as a part of moving to MWS.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61380412
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1604](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1604/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61380430
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Adrian Cole <no...@github.com>.
hmmm maybe this was already merged?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61663149
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Ignasi Barrera <no...@github.com>.
lgtm too
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61659834
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Adrian Cole <no...@github.com>.
Closed #72.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#event-188107177
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by Andrew Phillips <no...@github.com>.
Code changes themselves look fine to me - can't comment on any potential impact on downstream libs, but tests look good too ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61396135
Re: [jclouds-labs-google] Reduce or eliminate custom json type
adapter code (#72)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1621](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1621/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/72#issuecomment-61660725