[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #2939: xtensa/esp32: Refactor ESP32 WiFi driver to support station and softAP coexistence

[GitBox <gi...@apache.org>]

donghengqaz commented on a change in pull request #2939:
URL: https://github.com/apache/incubator-nuttx/pull/2939#discussion_r594014901



##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -3960,6 +4088,47 @@ static unsigned long esp_random_ulong(void)
   return esp_random();
 }
 
+/****************************************************************************
+ * Name: esp_wifi_tx_done_cb
+ *
+ * Description:
+ *   WiFi TX done callback function.
+ *
+ ****************************************************************************/
+
+static IRAM_ATTR void esp_wifi_tx_done_cb(uint8_t ifidx, uint8_t *data,
+                                          uint16_t *len, bool txstatus)
+{
+#if 0
+  wlinfo("INFO: ifidx=%d data=%p *len=%p txstatus=%d\n",
+         ifidx, data, len, txstatus);
+#endif

Review comment:
       About this, because I also don't want to enable this debugging unless it is necessary. Here will be called when packet id RX done, so this will lead to too much log.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org