You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/05/27 07:56:25 UTC
[GitHub] [fineract] logoutdhaval opened a new pull request, #2336: FINERACT-1613:Savings Interest Posting Job
logoutdhaval opened a new pull request, #2336:
URL: https://github.com/apache/fineract/pull/2336
## Description
[FINERACT:1613](https://issues.apache.org/jira/browse/FINERACT-1613).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj closed pull request #2336: FINERACT-1613:Savings Interest Posting Job
Posted by GitBox <gi...@apache.org>.
fynmanoj closed pull request #2336: FINERACT-1613:Savings Interest Posting Job
URL: https://github.com/apache/fineract/pull/2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj merged pull request #2336: FINERACT-1613:Savings Interest Posting Job
Posted by GitBox <gi...@apache.org>.
fynmanoj merged PR #2336:
URL: https://github.com/apache/fineract/pull/2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2336: FINERACT-1613:Savings Interest Posting Job
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2336:
URL: https://github.com/apache/fineract/pull/2336#issuecomment-1139533816
@fynmanoj @logoutdhaval It's really nice you've introduced a new test-case and helping with improving our coverage but I gotta say the test is still doing it the "old" way, i.e. it's using raw hashmaps and arraylists instead of using the fineract-client generated module. Do you mind spending some more time on this and get the proper models in place?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org