You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (Commented) (JIRA)" <ji...@apache.org> on 2011/12/05 00:18:39 UTC
[jira] [Commented] (HDFS-2626) HA:
BPOfferService.verifyAndSetNamespaceInfo needs to be synchronized
[ https://issues.apache.org/jira/browse/HDFS-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162518#comment-13162518 ]
Eli Collins commented on HDFS-2626:
-----------------------------------
+1 lgtm
> HA: BPOfferService.verifyAndSetNamespaceInfo needs to be synchronized
> ---------------------------------------------------------------------
>
> Key: HDFS-2626
> URL: https://issues.apache.org/jira/browse/HDFS-2626
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2626.txt
>
>
> When starting an HA blockpool with both namenodes up, I often see an NPE, referenced by one of the TODOs. The issue is the following interleaving:
> - first BPActor registers, and sets bpNSInfo in BPOfferService. It then proceeds to initFsDataset which takes a little bit of time
> - second BPActor registers, and sees bpNSInfo is non-null, then proceeds to heartbeat loop. Meanwhile BPActor 1 is still initting FSDataset
> - second BPActor gets an NPE on first heartbeat since fsdataset is still null.
> We just need to synchronize that function to fix the NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira