You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/06/28 13:37:57 UTC
Review Request 70970: Deactivated clang-tidy check
`clang-analyzer-cplusplus.Move`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70970/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Repository: mesos
Description
-------
This check which will be enabled by default with upstreams 8.0.0 release
has false positives in our codebase, see
https://bugs.llvm.org/show_bug.cgi?id=42433.
Diffs
-----
support/clang-tidy 8cb1662104e5cd41e62c9d573b33df55bc6c5d07
Diff: https://reviews.apache.org/r/70970/diff/1/
Testing
-------
`./support/mesos-tidy.sh`
Thanks,
Benjamin Bannier
Re: Review Request 70970: Deactivated clang-tidy check
`clang-analyzer-cplusplus.Move`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70970/#review216225
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On June 28, 2019, 1:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70970/
> -----------------------------------------------------------
>
> (Updated June 28, 2019, 1:37 p.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This check which will be enabled by default with upstreams 8.0.0 release
> has false positives in our codebase, see
> https://bugs.llvm.org/show_bug.cgi?id=42433.
>
>
> Diffs
> -----
>
> support/clang-tidy 8cb1662104e5cd41e62c9d573b33df55bc6c5d07
>
>
> Diff: https://reviews.apache.org/r/70970/diff/1/
>
>
> Testing
> -------
>
> `./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>