You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/10 12:12:07 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
LuciferYang opened a new pull request, #38189:
URL: https://github.com/apache/spark/pull/38189
### What changes were proposed in this pull request?
This PR aims to upgrade ASM to 9.4.
### Why are the changes needed?
xbean-asm9-shaded 4.22 upgrade to use ASM 9.4:
- https://github.com/apache/geronimo-xbean/pull/32
- https://asm.ow2.io/versions.html
- https://issues.apache.org/jira/browse/XBEAN-336
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38189:
URL: https://github.com/apache/spark/pull/38189#issuecomment-1273319188
<img width="598" alt="image" src="https://user-images.githubusercontent.com/1475305/194878106-7e6baff5-4a3d-4f2a-baf3-2670ca38b348.png">
It's a little strange. I can successfully build locally, but GA cannot download the new jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
URL: https://github.com/apache/spark/pull/38189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38189:
URL: https://github.com/apache/spark/pull/38189#issuecomment-1279922852
All passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38189:
URL: https://github.com/apache/spark/pull/38189#issuecomment-1274024210
LGTM pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38189:
URL: https://github.com/apache/spark/pull/38189#issuecomment-1273337180
covert to draft first and let's wait some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38189: [SPARK-40728][BUILD] Upgrade ASM to 9.4
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38189:
URL: https://github.com/apache/spark/pull/38189#issuecomment-1274035199
Sorry, we may need to wait a few days, I found it is still at [staging](https://repository.apache.org/content/groups/staging/org/apache/xbean/xbean-asm9-shaded/4.22/) .May be the Jfrog service I used locally delegate the staging ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org