You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 06:42:23 UTC
[GitHub] [flink-table-store] LadyForest opened a new pull request, #339: [FLINK-29790] Implement Catalog#getDatabase
LadyForest opened a new pull request, #339:
URL: https://github.com/apache/flink-table-store/pull/339
A minor change to implement `getDatabase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #339: [FLINK-29790] Implement Catalog#getDatabase
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #339:
URL: https://github.com/apache/flink-table-store/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #339: [FLINK-29790] Implement Catalog#getDatabase
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #339:
URL: https://github.com/apache/flink-table-store/pull/339#discussion_r1007734651
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/FlinkCatalog.java:
##########
@@ -90,6 +92,17 @@ public boolean databaseExists(String databaseName) throws CatalogException {
return catalog.databaseExists(databaseName);
}
+ @Override
+ public CatalogDatabase getDatabase(String databaseName) throws CatalogException {
+ try {
+ Database database = catalog.getDatabase(databaseName);
Review Comment:
I think we don't need to add `getDatabase` to `Catalog`, just `databaseExists` and return a empty `CatalogDatabase` for Flink Catalog is oK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org