[jira] [Commented] (HIVE-16612) PerfLogger is configurable, but not extensible

["Vineet Garg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424468#comment-16424468 ] 

Vineet Garg commented on HIVE-16612:
------------------------------------

Removing fix version to defer this to next release.

> PerfLogger is configurable, but not extensible
> ----------------------------------------------
>
>                 Key: HIVE-16612
>                 URL: https://issues.apache.org/jira/browse/HIVE-16612
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning, Query Processor
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
>         Attachments: HIVE-16612.01.patch, HIVE-16612.02.patch
>
>
> {code}
>           result = (PerfLogger) ReflectionUtils.newInstance(conf.getClassByName(
>             conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf);
> {code}
> The PerfLogger instance is configurable via {{hive.exec.perf.logger}} (HIVE-11891) but the requirement to extend from {{PerfLogger}} cannot be met since HIVE-11149 as the ctor is private. Also useful methods in PerfLogger are also private. I tried to extend PerfLogger for my needs and realized that, as is, the configurability is not usable. At the very least the PerfLogger should make all private members {{protected}}, better the requirement should be an interface not a class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)