You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 00:05:43 UTC

[GitHub] [airflow] dstandish removed a comment on pull request #13050: airflow should use same JSONEncoder as flask

dstandish removed a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086704


   maybe it makes sense to leave dag serialization json always with `json`, assuming it doesn't have any interactions with flask.
   
   however i did notice its location and naming (`from airflow.settings import json`) make it seem "global", i.e. not just for dag serde, which could lead to confusion.  maybe makes sense to rename e.g. `dag_serde_json` or something so it's clear it's for specific subset of uses... but this is above my pay grade :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org