[jira] [Work logged] (BEAM-10137) Add cross-language wrapper for Java's KinesisIO Read

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-10137?focusedWorklogId=477315&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477315 ]

ASF GitHub Bot logged work on BEAM-10137:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Sep/20 16:26
            Start Date: 01/Sep/20 16:26
    Worklog Time Spent: 10m 
      Work Description: aromanenko-dev commented on a change in pull request #12297:
URL: https://github.com/apache/beam/pull/12297#discussion_r481276587



##########
File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -295,14 +300,16 @@
   private static final int DEFAULT_NUM_RETRIES = 6;
 
   /** Returns a new {@link Read} transform for reading from Kinesis. */
-  public static Read read() {
-    return new AutoValue_KinesisIO_Read.Builder()
-        .setMaxNumRecords(Long.MAX_VALUE)
-        .setUpToDateThreshold(Duration.ZERO)
-        .setWatermarkPolicyFactory(WatermarkPolicyFactory.withArrivalTimePolicy())
-        .setRateLimitPolicyFactory(RateLimitPolicyFactory.withoutLimiter())
-        .setMaxCapacityPerShard(ShardReadersPool.DEFAULT_CAPACITY_PER_SHARD)
-        .build();
+  public static Read<KinesisRecord> read() {

Review comment:
       I think it should be fine if it doesn't require a user code changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 477315)
    Time Spent: 13h 10m  (was: 13h)

> Add cross-language wrapper for Java's KinesisIO Read
> ----------------------------------------------------
>
>                 Key: BEAM-10137
>                 URL: https://issues.apache.org/jira/browse/BEAM-10137
>             Project: Beam
>          Issue Type: Sub-task
>          Components: cross-language, io-java-kinesis, io-py-aws
>    Affects Versions: Not applicable
>            Reporter: Piotr Szuberski
>            Assignee: Piotr Szuberski
>            Priority: P2
>              Labels: portability
>             Fix For: Not applicable
>
>          Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's KinesisIO Read



--
This message was sent by Atlassian Jira
(v8.3.4#803005)