[GitHub] [incubator-yunikorn-core] TaoYang526 edited a comment on issue #96: [YUNIKORN-1] Support app/task priority aware scheduling

[GitBox <gi...@apache.org>]

TaoYang526 edited a comment on issue #96: [YUNIKORN-1] Support app/task priority aware scheduling
URL: https://github.com/apache/incubator-yunikorn-core/pull/96#issuecomment-596368653
 
 
   Thanks @yangwwei for the review and comments.
   Replies about the comments above:
   1. LGTM
   2. (1) matchFunc helps to locate the first pending request so that we can quickly find out the top priority group and the first pending request in a priority group, otherwise we have to iterate all requests to find pending request for every cycle. 
   (2)isFixedOrder can be used for different scenarios, for now the priority of request can't be modified so that we can set isFixedOrder to true to avoid reordering this request in the map, but if we support updating the priority in the future, we can set isFixedOrder to false. But it's fine for me to move it and not support resorting when updating the entry.
   3. We have lots of operations need to get request by allocationKey, if not keep all requests in map, we have to find it from priority groups, perhaps it's fine to keep references in several places for better performance?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org