You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/03/23 19:53:25 UTC
[GitHub] [tomcat] HoffmannTom opened a new pull request #487: Improved logging of unknown http2 settings
HoffmannTom opened a new pull request #487:
URL: https://github.com/apache/tomcat/pull/487
The logging of unknown http2 settings should contain the key and the value of the setting.
The key is currently converted into a setting object. Unknown keys are mapped to Integer.MAX_VALUE
Thus the log currently contains the MAX_VALUE as key and the value of the settings. The original key got lost during the conversion to the setting object.
Therefore the logging was moved to methods, which have access to the original key and the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #487: Improved logging of unknown http2 settings
Posted by GitBox <gi...@apache.org>.
rmaucher commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076761134
Closing since the patch is wrong and I'm already about to commit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] HoffmannTom commented on pull request #487: Improved logging of unknown http2 settings
Posted by GitBox <gi...@apache.org>.
HoffmannTom commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076767607
Thank you for the quick response and help!
My second pull request in future will hopefully improve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #487: Improved logging of unknown http2 settings
Posted by GitBox <gi...@apache.org>.
rmaucher commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076764682
Oh, actually, this has the key -> id change, but it should still do Integer.toString(id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher closed pull request #487: Improved logging of unknown http2 settings
Posted by GitBox <gi...@apache.org>.
rmaucher closed pull request #487:
URL: https://github.com/apache/tomcat/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org