[GitHub] [cassandra] maedhroz commented on a change in pull request #708: CASSANDRA-15977 4.0 quality testing: Read Repair

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #708:
URL: https://github.com/apache/cassandra/pull/708#discussion_r483788447



##########
File path: test/distributed/org/apache/cassandra/distributed/test/TestBaseImpl.java
##########
@@ -43,4 +51,29 @@ public static void beforeClass() throws Throwable {
         // fact that this code is going to work accross _all_ versions.
         return Cluster.build();
     }
+
+    public static Object list(Object...values)
+    {
+        return CQLTester.list(values);
+    }
+
+    public static Object set(Object...values)
+    {
+        return CQLTester.set(values);
+    }
+
+    public static Object map(Object...values)
+    {
+        return CQLTester.map(values);
+    }
+
+    public static ByteBuffer tuple(Object... values)
+    {
+        return CQLTester.tuple(values).toByteBuffer();
+    }
+
+    public static ByteBuffer udt(Object... values)
+    {
+        return CQLTester.userType(values).toByteBuffer();
+    }

Review comment:
       @adelapena One thing we have to watch out for is that the long term plan for in-JVM dtests might involve them being in a separate repository. If that happens, the dependency on `CQLTester` might not be possible. For now, perhaps it would be best to just import the static methods from `CQLTester` and leave this uncluttered (and deal with that problem when we have to).
   
   CC @ifesdjeen @dcapwell 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org