You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/27 13:49:49 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4958: Improve logs on agent start

GutoVeronezi opened a new pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958


   ### Description
   This PR intends to improve logging on agent start to facilitate troubleshooting.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functioanlity)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   It has been tested locally on a test lab.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-831240336


   <b>Trillian Build Failed (tid-596)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r645748094



##########
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##########
@@ -2436,6 +2436,9 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
         host.setHypervisorType(hyType);
         host.setHypervisorVersion(ssCmd.getHypervisorVersion());
         host.setGpuGroups(ssCmd.getGpuGroupDetails());
+
+        s_logger.info(String.format("Filling %s with the following information retrieved from the agent {\"cpus\": %s, \"cpuSpeed\": %s, \"cpuSockets\": %s, "

Review comment:
       You are right. 
   
   Repeated logs were removed, thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r648826072



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -42,6 +42,8 @@
     private long overCommitMemory;
     private List<String> capabilities = new ArrayList<>();
 
+    public static String cpuInfoMaxFreqFileName = "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq";

Review comment:
       It seems that this variable could be private.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-831240336


   <b>Trillian Build Failed (tid-596)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830078483


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-831296162


   <b>Trillian Build Failed (tid-598)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-837690695


   <b>Trillian test result (tid-637)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 54478 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4958-t637-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 87 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_ping_in_vr_success | `Failure` | 15.35 | test_diagnostics.py
   test_05_ping_in_cpvm_success | `Failure` | 6.19 | test_diagnostics.py
   test_07_arping_in_vr | `Failure` | 5.16 | test_diagnostics.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830108394






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830354179


   @sureshanaparti @GabrielBrascher done.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-859624201


   Let me get back to this next week or the week after, sorry I've been busy with 4.15 release and PRs related to 4.15 and other work stuff. I hope there's no urgency to get these PRs merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r626510183



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -125,7 +128,10 @@ private void getHostInfoFromLibvirt() {
             */
             this.capabilities.add("snapshot");
             conn.close();
-        } catch (final LibvirtException e) {
+
+            LOGGER.info(String.format("Fetched the following host's information {\"cpus\": %s, \"cpuSpeed\": %s, \"cpuSockets\": %s, \"cpuNodes\": %s, \"capabilities\": \"%s\"}.",
+              hosts.cpus,this.cpuSpeed, hosts.sockets, hosts.nodes, this.capabilities.toString()));

Review comment:
       ```suggestion
                 hosts.cpus, this.cpuSpeed, hosts.sockets, hosts.nodes, this.capabilities.toString()));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-859479998






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830104053


   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r622403770



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -78,11 +80,12 @@ public long getOverCommitMemory() {
     }
 
     protected static long getCpuSpeed(final NodeInfo nodeInfo) {
-        try (final Reader reader = new FileReader(
-                "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq")) {
-            return Long.parseLong(IOUtils.toString(reader).trim()) / 1000;
+        try (Reader reader = new FileReader(cpuInfoMaxFreqFileName)) {
+            Long cpuInfoMaxFreq = Long.parseLong(IOUtils.toString(reader).trim());
+            LOGGER.info(String.format("Retrieved value [%s] from file [%s]. Using the value divided by 1000 [%s] as CPU speed value.", cpuInfoMaxFreq, cpuInfoMaxFreqFileName, cpuInfoMaxFreq / 1000));
+            return cpuInfoMaxFreq / 1000;
         } catch (IOException | NumberFormatException e) {
-            LOGGER.info("Could not read cpuinfo_max_freq, falling back on libvirt");
+            LOGGER.error(String.format("Unable to retrieve the CPU speed from file [%s]. Using using the value [%s] provided by the Libvirt.", cpuInfoMaxFreqFileName, nodeInfo.mhz), e);

Review comment:
       @sureshanaparti done. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-854458383


   @sureshanaparti @rhtyd are you guys all right with this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-831213666


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 511


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r622156949



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -78,11 +80,12 @@ public long getOverCommitMemory() {
     }
 
     protected static long getCpuSpeed(final NodeInfo nodeInfo) {
-        try (final Reader reader = new FileReader(
-                "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq")) {
-            return Long.parseLong(IOUtils.toString(reader).trim()) / 1000;
+        try (Reader reader = new FileReader(cpuInfoMaxFreqFileName)) {
+            Long cpuInfoMaxFreq = Long.parseLong(IOUtils.toString(reader).trim());
+            LOGGER.info(String.format("Retrieved value [%s] from file [%s]. Using the value divided by 1000 [%s] as CPU speed value.", cpuInfoMaxFreq, cpuInfoMaxFreqFileName, cpuInfoMaxFreq / 1000));
+            return cpuInfoMaxFreq / 1000;
         } catch (IOException | NumberFormatException e) {
-            LOGGER.info("Could not read cpuinfo_max_freq, falling back on libvirt");
+            LOGGER.error(String.format("Unable to retrieve the CPU speed from file [%s]. Using using the value [%s] provided by the Libvirt.", cpuInfoMaxFreqFileName, nodeInfo.mhz), e);

Review comment:
       _Using_ repeated in log ^^^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r626816536



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -125,7 +128,10 @@ private void getHostInfoFromLibvirt() {
             */
             this.capabilities.add("snapshot");
             conn.close();
-        } catch (final LibvirtException e) {
+
+            LOGGER.info(String.format("Fetched the following host's information {\"cpus\": %s, \"cpuSpeed\": %s, \"cpuSockets\": %s, \"cpuNodes\": %s, \"capabilities\": \"%s\"}.",
+              hosts.cpus,this.cpuSpeed, hosts.sockets, hosts.nodes, this.capabilities.toString()));

Review comment:
       @sureshanaparti done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-831631691


   <b>Trillian test result (tid-600)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33636 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4958-t600-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r622158407



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -78,11 +80,12 @@ public long getOverCommitMemory() {
     }
 
     protected static long getCpuSpeed(final NodeInfo nodeInfo) {
-        try (final Reader reader = new FileReader(
-                "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq")) {
-            return Long.parseLong(IOUtils.toString(reader).trim()) / 1000;
+        try (Reader reader = new FileReader(cpuInfoMaxFreqFileName)) {
+            Long cpuInfoMaxFreq = Long.parseLong(IOUtils.toString(reader).trim());
+            LOGGER.info(String.format("Retrieved value [%s] from file [%s]. Using the value divided by 1000 [%s] as CPU speed value.", cpuInfoMaxFreq, cpuInfoMaxFreqFileName, cpuInfoMaxFreq / 1000));

Review comment:
       you can log the value, i think no need to explicitly specify 'divided by 1000'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-836478711


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r624142836



##########
File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/linux/KVMHostInfo.java
##########
@@ -78,11 +80,12 @@ public long getOverCommitMemory() {
     }
 
     protected static long getCpuSpeed(final NodeInfo nodeInfo) {
-        try (final Reader reader = new FileReader(
-                "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq")) {
-            return Long.parseLong(IOUtils.toString(reader).trim()) / 1000;
+        try (Reader reader = new FileReader(cpuInfoMaxFreqFileName)) {
+            Long cpuInfoMaxFreq = Long.parseLong(IOUtils.toString(reader).trim());
+            LOGGER.info(String.format("Retrieved value [%s] from file [%s]. Using the value divided by 1000 [%s] as CPU speed value.", cpuInfoMaxFreq, cpuInfoMaxFreqFileName, cpuInfoMaxFreq / 1000));

Review comment:
       This log is an interesting one. Also making it info seems reasonable as it is a piece of information regarding the agent and it logs only when the service starts.
   
   Regarding @sureshanaparti comment's, I am also thinking of some options that might be better than the `divided by 1000`.
   
   As an example, let's say that a host has a CPU speed of `2000 MHz`. The `cpuinfo_max_freq` file should then hold the value of `2000000` (at least that's what I get when running KVM on Ubuntu)
   
   In that example, it would then log:
   `Retrieved value [2000000] from file [/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq]. Using the value divided by 1000 [2000] as CPU speed value.`
   
   What do you think of changing to something such as:
   `Retrieved value [2000000] from file [/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq]. This corresponds to a CPU speed of 2000 MHz.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830113647


   <b>Trillian Build Failed (tid-576)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-830103752


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-854642309


   > @sureshanaparti @rhtyd are you guys all right with this?
   
   @DaanHoogland seems there are some unaddressed comments. @GutoVeronezi can you please check and resolve all the comments. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4958: Improve logs on agent start

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#discussion_r621993154



##########
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##########
@@ -2436,6 +2436,9 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
         host.setHypervisorType(hyType);
         host.setHypervisorVersion(ssCmd.getHypervisorVersion());
         host.setGpuGroups(ssCmd.getGpuGroupDetails());
+
+        s_logger.info(String.format("Filling %s with the following information retrieved from the agent {\"cpus\": %s, \"cpuSpeed\": %s, \"cpuSockets\": %s, "

Review comment:
       Logging may not be necessary if it's a command that is sent from agent. There is log statement that should cover it already (on either mgmt  server/agent side)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org