You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ylnsnv (via GitHub)" <gi...@apache.org> on 2023/11/07 07:18:16 UTC
[PR] Optimized cursor retrieval in PostgresHook. [airflow]
ylnsnv opened a new pull request, #35498:
URL: https://github.com/apache/airflow/pull/35498
Refactored the `_get_cursor` method for improved efficiency and error handling.
The method now uses a dictionary for cursor type lookup, streamlining the addition of future cursor types and providing clearer error messages for invalid cursors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor cursor retrieval in PostgresHook. [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35498:
URL: https://github.com/apache/airflow/pull/35498#issuecomment-1798391050
NIT: (changed the name) It's refactor, not optimisation :). It's llikely (not sure) lest optimized than previous code but indeed nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor cursor retrieval in PostgresHook. [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #35498:
URL: https://github.com/apache/airflow/pull/35498#issuecomment-1798817256
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor cursor retrieval in PostgresHook. [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #35498:
URL: https://github.com/apache/airflow/pull/35498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor cursor retrieval in PostgresHook. [airflow]
Posted by "ylnsnv (via GitHub)" <gi...@apache.org>.
ylnsnv commented on PR #35498:
URL: https://github.com/apache/airflow/pull/35498#issuecomment-1798624987
I've just, hopefully, fixed the failing tests from the last time you approved by running the pre-commit (my bad for not running it earlier), @potiuk thanks for reviewing! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor cursor retrieval in PostgresHook. [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35498:
URL: https://github.com/apache/airflow/pull/35498#issuecomment-1798387875
NIT: (changed the name) It's refactotr, not optimisatio. It's llikely (not sure) lest optimized than previous code but indeed nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org