You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2016/08/11 20:43:40 UTC
[3/3] incubator-mynewt-core git commit: BLE Ctlr - max evt sz too low
for rd-lcl-sup-ftrs
BLE Ctlr - max evt sz too low for rd-lcl-sup-ftrs
In a previous commit (8b8d887358be1d64e6002fb4efb6b4e0673a1760), the max
event size was reduced from 260 to 45. The belief was that the largest
event the NimBLE controller sends is 45 bytes (advertising report with
one entry, entry has 0x1f data bytes). However, the controller's
response to the read-local-supported-features HCI command is larger:
0x44 + 2 byte header = 0x46 (70).
Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/commit/3b6e2f10
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/tree/3b6e2f10
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/diff/3b6e2f10
Branch: refs/heads/develop
Commit: 3b6e2f10b034f367320addba2cf1372637e24f36
Parents: c7511b3
Author: Christopher Collins <cc...@apache.org>
Authored: Thu Aug 11 13:39:53 2016 -0700
Committer: Christopher Collins <cc...@apache.org>
Committed: Thu Aug 11 13:39:53 2016 -0700
----------------------------------------------------------------------
net/nimble/controller/include/controller/ble_ll_hci.h | 2 +-
net/nimble/transport/ram/src/ble_hci_ram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/blob/3b6e2f10/net/nimble/controller/include/controller/ble_ll_hci.h
----------------------------------------------------------------------
diff --git a/net/nimble/controller/include/controller/ble_ll_hci.h b/net/nimble/controller/include/controller/ble_ll_hci.h
index 43b98fc..e3a7e3e 100644
--- a/net/nimble/controller/include/controller/ble_ll_hci.h
+++ b/net/nimble/controller/include/controller/ble_ll_hci.h
@@ -25,7 +25,7 @@
extern const uint8_t g_ble_ll_supp_cmds[BLE_LL_SUPP_CMD_LEN];
/* The largest event the controller will send. */
-#define BLE_LL_MAX_EVT_LEN (45)
+#define BLE_LL_MAX_EVT_LEN (70)
/*
* This determines the number of outstanding commands allowed from the
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-core/blob/3b6e2f10/net/nimble/transport/ram/src/ble_hci_ram.c
----------------------------------------------------------------------
diff --git a/net/nimble/transport/ram/src/ble_hci_ram.c b/net/nimble/transport/ram/src/ble_hci_ram.c
index ef46309..f5191b8 100644
--- a/net/nimble/transport/ram/src/ble_hci_ram.c
+++ b/net/nimble/transport/ram/src/ble_hci_ram.c
@@ -10,10 +10,10 @@
/** Default configuration. */
const struct ble_hci_ram_cfg ble_hci_ram_cfg_dflt = {
.num_evt_hi_bufs = 2,
- .num_evt_lo_bufs = 12,
+ .num_evt_lo_bufs = 8,
/* The largest event the nimble controller will send is 45 bytes. */
- .evt_buf_sz = 45,
+ .evt_buf_sz = 70,
};
static ble_hci_trans_rx_cmd_fn *ble_hci_ram_rx_cmd_hs_cb;