You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 01:12:51 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10900: docs: redirect http -> https
mistercrunch opened a new pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900
### SUMMARY
because <img width="941" alt="Screen Shot 2020-09-14 at 10 51 34 PM" src="https://user-images.githubusercontent.com/487433/93280645-fe250380-f77e-11ea-9241-5ab2a7a6fc86.png">
does NOT look good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489215067
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts
##########
@@ -64,7 +64,7 @@ describe('AdhocFilters', () => {
});
});
- it('Set custom adhoc filter', () => {
+ xit('Set custom adhoc filter', () => {
Review comment:
This PR just got a lot more controversial! I'm inclined to approve, but hope we can fix this test one day, as it HAS caught real errors for me before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489504334
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts
##########
@@ -64,7 +64,7 @@ describe('AdhocFilters', () => {
});
});
- it('Set custom adhoc filter', () => {
+ xit('Set custom adhoc filter', () => {
Review comment:
I'M GOING CRAZY DEALING WITH FLAKY TESTS.
FYI that's the second flaky test in this module. Another one got fixed by @nytai yesterday
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489213845
##########
File path: docs/README.md
##########
@@ -1,21 +1,20 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
+[//]: # Licensed to the Apache Software Foundation (ASF) under one
Review comment:
~~Hah, I have [another PR](https://github.com/apache/incubator-superset/pull/10898) open for some redirect support, and it seems like you can get away with just the `# ` for comments. Well, we'll see if it passes CI.~~
Nevermind... the above is great if you like GIANT text. I need sleep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489103777
##########
File path: docs/.htaccess
##########
@@ -0,0 +1,3 @@
+RewriteEngine On
Review comment:
here's the redirect magic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489225686
##########
File path: docs/README.md
##########
@@ -1,21 +1,20 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
+[//]: # Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Hmmm. The comment format in this PR is still visible on the readme too... not sure what the trick is here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489103447
##########
File path: docs/README.md
##########
@@ -1,21 +1,20 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
+[//]: # Licensed to the Apache Software Foundation (ASF) under one
Review comment:
gatsby-mdx was tripping on the comment...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489213845
##########
File path: docs/README.md
##########
@@ -1,21 +1,20 @@
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
+[//]: # Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Hah, I have [another PR](https://github.com/apache/incubator-superset/pull/10898) open for some redirect support, and it seems like you can get away with just the `# ` for comments. Well, we'll see if it passes CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#discussion_r489214246
##########
File path: docs/README.md
##########
@@ -37,7 +36,7 @@ npm run start
To publish, the static site that Gatsby generates needs to be pushed
to the `asf-site` branch on the
[apache/incubator-superset-site](https://github.com/apache/incubator-superset-site/)
-repository. No need to PR here, just `git push`!
+repository. No need to PR here, simply `git push`.
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10900: docs: redirect http -> https
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10900:
URL: https://github.com/apache/incubator-superset/pull/10900#issuecomment-693462344
I'd say merge this and let's get back to the xits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org