[GitHub] nswamy commented on a change in pull request #10181: generate Scala documentation for infer package

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #10181: generate Scala documentation for infer package
URL: https://github.com/apache/incubator-mxnet/pull/10181#discussion_r176177644
 
 

 ##########
 File path: docs/mxdoc.py
 ##########
 @@ -80,9 +80,9 @@ def build_r_docs(app):
 
 def build_scala_docs(app):
     """build scala doc and then move the outdir"""
-    scala_path = app.builder.srcdir + '/../scala-package/core/src/main/scala/ml/dmlc/mxnet'
+    scala_path = app.builder.srcdir + '/../scala-package'
     # scaldoc fails on some apis, so exit 0 to pass the check
-    _run_cmd('cd ' + scala_path + '; scaladoc `find . | grep .*scala`; exit 0')
+    _run_cmd('cd ' + scala_path + '; scaladoc `find . -type f -name "*.scala" | egrep \"\/core|\/infer\" | egrep -v \"Suite\"`; exit 0')
 
 Review comment:
   Yes, I have tested locally. This not how configuration should be dealt- hardcoding(I think that needs to be a separate task). I tweaked the existing code to add new classes that we worked on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services