You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "Kazuomi Kashii (JIRA)" <ji...@apache.org> on 2012/06/05 16:47:24 UTC
[jira] [Created] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Kazuomi Kashii created GORA-143:
-----------------------------------
Summary: GoraCompiler needs to add "import FixedSize" statement for FIXED type
Key: GORA-143
URL: https://issues.apache.org/jira/browse/GORA-143
Project: Apache Gora
Issue Type: Bug
Components: schema
Reporter: Kazuomi Kashii
Since GoraCompiler does not write the following import statement:
import org.apache.avro.specific.FixedSize;
for FIXED type like:
{ "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
javac cannot compile the FIXED type class generated by GoraCompiler like:
src/MD5.java:24: cannot find symbol
symbol: class FixedSize
@FixedSize(16)
^
GoraCompiler should write:
import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney closed GORA-143.
-------------------------------------
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.2.1
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Kazuomi Kashii (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kazuomi Kashii updated GORA-143:
--------------------------------
Attachment: GORA-143-v2.patch
In addition to @FixedSize,
GoraCompiler does not write set/get method for FIXED field,
because "case" statement is missing.
This GORA-143-v2.patch includes this fix, too.
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Reporter: Kazuomi Kashii
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409681#comment-13409681 ]
Ferdy Galema commented on GORA-143:
-----------------------------------
+1
I tested this and it works like a charm.
Two remarks:
-Like noted in the mailing list by Lewis please don't forget to add an entry to CHANGES.txt
-A small nit: Next time when committing you should put the issue number in the commit message without a postfix. You postfixed a "." (dot) which prevents it from being listed in this issue as a commit.
Thanks!
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.3
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Kazuomi Kashii (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411665#comment-13411665 ]
Kazuomi Kashii commented on GORA-143:
-------------------------------------
Ferdy, thanks for your tip about postfix "." of commit message. I did not know that.
I have added the description about GORA-143 to CHANGES.txt and committed.
Also, updates the resolution of this bug to FIXED.
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.3
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney updated GORA-143:
--------------------------------------
Affects Version/s: 0.2
Fix Version/s: 0.3
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.3
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Kazuomi Kashii (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kazuomi Kashii resolved GORA-143.
---------------------------------
Resolution: Fixed
Sending CHANGES.txt
Committed revision 1360245.
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.3
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney updated GORA-143:
--------------------------------------
Fix Version/s: (was: 0.3)
0.2.1
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Affects Versions: 0.2
> Reporter: Kazuomi Kashii
> Fix For: 0.2.1
>
> Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-143) GoraCompiler needs to add "import
FixedSize" statement for FIXED type
Posted by "Kazuomi Kashii (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kazuomi Kashii updated GORA-143:
--------------------------------
Attachment: GORA-143.patch
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
> Key: GORA-143
> URL: https://issues.apache.org/jira/browse/GORA-143
> Project: Apache Gora
> Issue Type: Bug
> Components: schema
> Reporter: Kazuomi Kashii
> Attachments: GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
> { "name": "md5", "type": { "type" : "fixed", "size" : 16, "name" : "MD5" } },
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
> ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira