You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by rw...@apache.org on 2019/06/12 16:33:39 UTC
svn commit: r1861148 - in /pivot/trunk/tests/src/org/apache/pivot/tests:
BXMLDictionaryTest.java EnumBeanTest.java JSONBeanTest.java
MessageBusTest.java ResultListTest.java issues/Pivot751WithoutGUI.java
Author: rwhitcomb
Date: Wed Jun 12 16:33:39 2019
New Revision: 1861148
URL: http://svn.apache.org/viewvc?rev=1861148&view=rev
Log:
PIVOT-1032: Get rid of HideUtilityClassConstructor errors everywhere
(all were test programs at this point).
Modified:
pivot/trunk/tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java
pivot/trunk/tests/src/org/apache/pivot/tests/EnumBeanTest.java
pivot/trunk/tests/src/org/apache/pivot/tests/JSONBeanTest.java
pivot/trunk/tests/src/org/apache/pivot/tests/MessageBusTest.java
pivot/trunk/tests/src/org/apache/pivot/tests/ResultListTest.java
pivot/trunk/tests/src/org/apache/pivot/tests/issues/Pivot751WithoutGUI.java
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java Wed Jun 12 16:33:39 2019
@@ -20,7 +20,10 @@ import org.apache.pivot.beans.BXMLSerial
import org.apache.pivot.collections.HashMap;
import org.apache.pivot.json.JSONSerializer;
-public class BXMLDictionaryTest {
+public final class BXMLDictionaryTest {
+ /** Hide utility class constructor. */
+ private BXMLDictionaryTest() { }
+
public static void main(String[] args) throws Exception {
BXMLSerializer bxmlSerializer = new BXMLSerializer();
@SuppressWarnings("unchecked")
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/EnumBeanTest.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/EnumBeanTest.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/EnumBeanTest.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/EnumBeanTest.java Wed Jun 12 16:33:39 2019
@@ -24,17 +24,18 @@ import org.apache.pivot.beans.BeanAdapte
import org.apache.pivot.serialization.SerializationException;
import org.apache.pivot.wtk.Orientation;
-public class EnumBeanTest {
- public static void main(String[] args) {
+public final class EnumBeanTest {
+ /** Hide utility class constructor. */
+ private EnumBeanTest() { }
+ public static void main(String[] args) {
BXMLSerializer bxmlSerializer = new BXMLSerializer();
+
try {
EnumBean enumBean = (EnumBean) bxmlSerializer.readObject(EnumBeanTest.class,
"enum_bean.bxml");
System.out.println("Bean read OK - " + enumBean);
- } catch (IOException e) {
- e.printStackTrace();
- } catch (SerializationException e) {
+ } catch (IOException | SerializationException e) {
e.printStackTrace();
}
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/JSONBeanTest.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/JSONBeanTest.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/JSONBeanTest.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/JSONBeanTest.java Wed Jun 12 16:33:39 2019
@@ -18,7 +18,7 @@ package org.apache.pivot.tests;
import org.apache.pivot.json.JSONSerializer;
-public class JSONBeanTest {
+public final class JSONBeanTest {
public static class A {
public String greeting = "Hello World";
@@ -42,6 +42,9 @@ public class JSONBeanTest {
}
}
+ /** Hide utility class constructor. */
+ private JSONBeanTest() { }
+
public static void main(String[] args) throws Exception {
A a = new A();
System.out.println(JSONSerializer.toString(a));
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/MessageBusTest.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/MessageBusTest.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/MessageBusTest.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/MessageBusTest.java Wed Jun 12 16:33:39 2019
@@ -19,7 +19,10 @@ package org.apache.pivot.tests;
import org.apache.pivot.util.MessageBus;
import org.apache.pivot.util.MessageBusListener;
-public class MessageBusTest {
+public final class MessageBusTest {
+ /** Hide utility class constructor. */
+ private MessageBusTest() { }
+
public enum TestMessage {
HELLO, GOODBYE
}
@@ -36,7 +39,6 @@ public class MessageBusTest {
MessageBus.sendMessage(TestMessage.HELLO); // a message will be printed
MessageBus.unsubscribe(TestMessage.class, testMessageListener); // unsubscribe
- MessageBus.sendMessage(TestMessage.GOODBYE); // the message will not be
- // printed
+ MessageBus.sendMessage(TestMessage.GOODBYE); // the message will not be printed
}
}
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/ResultListTest.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/ResultListTest.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/ResultListTest.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/ResultListTest.java Wed Jun 12 16:33:39 2019
@@ -28,7 +28,10 @@ import org.apache.pivot.collections.Map;
import org.apache.pivot.json.JSONSerializer;
import org.apache.pivot.sql.ResultList;
-public class ResultListTest {
+public final class ResultListTest {
+ /** Hide utility class constructor. */
+ private ResultListTest() { }
+
public static void main(String[] args) throws Exception {
// e.g. jdbc:mysql://localhost/test
String connectionURL = args[0];
Modified: pivot/trunk/tests/src/org/apache/pivot/tests/issues/Pivot751WithoutGUI.java
URL: http://svn.apache.org/viewvc/pivot/trunk/tests/src/org/apache/pivot/tests/issues/Pivot751WithoutGUI.java?rev=1861148&r1=1861147&r2=1861148&view=diff
==============================================================================
--- pivot/trunk/tests/src/org/apache/pivot/tests/issues/Pivot751WithoutGUI.java (original)
+++ pivot/trunk/tests/src/org/apache/pivot/tests/issues/Pivot751WithoutGUI.java Wed Jun 12 16:33:39 2019
@@ -21,7 +21,10 @@ import org.apache.pivot.wtk.Label;
import org.apache.pivot.wtk.TabPane;
import org.apache.pivot.wtk.TabPaneSelectionListener;
-public class Pivot751WithoutGUI implements Application {
+public final class Pivot751WithoutGUI implements Application {
+
+ /** Hide utility class constructor. */
+ private Pivot751WithoutGUI() { }
public static void main(String[] args) {
final TabPane tabPane = new TabPane();