You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/08/15 21:44:04 UTC

[Impala-ASF-CR] IMPALA-3200: More end-to-end tests

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3200: More end-to-end tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7668/2/tests/verifiers/metric_verifier.py
File tests/verifiers/metric_verifier.py:

PS2, Line 33:                "buffer-pool.clean-pages",
            :                "buffer-pool.clean-page-bytes"
these will get checked in tests/verifiers/test_verify_metrics.py now -- but that test doesn't have the memory_maintenance_sleep_time_ms set low. Are you sure this won't be flaky there?


-- 
To view, visit http://gerrit.cloudera.org:8080/7668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3b6adf5b97b16594c6c4855d5fa831c5a90e10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes