You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 20:12:40 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
rkhachatryan opened a new pull request #13734:
URL: https://github.com/apache/flink/pull/13734
Backport of #13709 to 1.11
## What is the purpose of the change
If checkpoints in ZK are the same as already downloaded then skip
download. This prevents excessive S3 reads and eventually failure to
start the job, particularly in multi-region recovery.
## Verifying this change
Added `testNoDownloadIfCheckpointsNotChanged` and `testDownloadIfCheckpointsChanged` to `ZooKeeperCompletedCheckpointStoreTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
}, {
"hash" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8048",
"triggerID" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"triggerType" : "PUSH"
}, {
"hash" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047",
"triggerID" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
* 1fe3613e0159e9508c1171c6bbaa666d6029072f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #13734:
URL: https://github.com/apache/flink/pull/13734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
}, {
"hash" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"triggerType" : "PUSH"
}, {
"hash" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
* e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce UNKNOWN
* 1fe3613e0159e9508c1171c6bbaa666d6029072f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
}, {
"hash" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8048",
"triggerID" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"triggerType" : "PUSH"
}, {
"hash" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047",
"triggerID" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
* e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8048)
* 1fe3613e0159e9508c1171c6bbaa666d6029072f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713847303
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 579ce0811c6f1f9db73f832e7291e0ea2d642e12 (Wed Oct 21 20:14:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
}, {
"hash" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
* e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13734: (1.11 backport) [FLINK-19401][checkpointing] Download checkpoints only if needed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13734:
URL: https://github.com/apache/flink/pull/13734#issuecomment-713860781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "579ce0811c6f1f9db73f832e7291e0ea2d642e12",
"triggerType" : "PUSH"
}, {
"hash" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8048",
"triggerID" : "e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce",
"triggerType" : "PUSH"
}, {
"hash" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047",
"triggerID" : "1fe3613e0159e9508c1171c6bbaa666d6029072f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 579ce0811c6f1f9db73f832e7291e0ea2d642e12 UNKNOWN
* e517e7d0eb27b285a0b8a4ca0b85a64e8b1466ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8048)
* 1fe3613e0159e9508c1171c6bbaa666d6029072f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org