[GitHub] [spark] amaliujia commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #37746:
URL: https://github.com/apache/spark/pull/37746#discussion_r960036859


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -844,10 +846,6 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
       s"Cannot delete from table ${table.name} where ${filters.mkString("[", ", ", "]")}")
   }
 
-  def deleteOnlySupportedWithV2TablesError(): Throwable = {

Review Comment:
   Why did? Is it not longer used after this factoring? 



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -844,10 +846,6 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
       s"Cannot delete from table ${table.name} where ${filters.mkString("[", ", ", "]")}")
   }
 
-  def deleteOnlySupportedWithV2TablesError(): Throwable = {

Review Comment:
   Why delete? Is it not longer used after this factoring? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org