You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Dawid Weiss (Jira)" <ji...@apache.org> on 2021/09/01 19:55:00 UTC
[jira] [Commented] (SOLR-15610) Support json formatted logging via
conf: add log4j-layout-template-json to 'server'
[ https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408351#comment-17408351 ]
Dawid Weiss commented on SOLR-15610:
------------------------------------
I'm not sure. Looks like this configuration is not included in what palantir's plugin considers for resolution?
https://github.com/palantir/gradle-consistent-versions#versionslock-compact-representation-of-your-prod-classpath
"The lockfile sources production dependencies from the compileClasspath and runtimeClasspath configurations, and test dependencies from the compile/runtime classpaths of any source set that ends in test (e.g. test, integrationTest, eteTest)."
But then it says that the constraints are applied to all configurations (that's why it works, I guess):
"By default, this plugin will apply the constraints from versions.props to all configurations."
I'm really not sure what's happening here. I can take a deeper look if you wish, but I admit I have other things on my plate now...
> Support json formatted logging via conf: add log4j-layout-template-json to 'server'
> -----------------------------------------------------------------------------------
>
> Key: SOLR-15610
> URL: https://issues.apache.org/jira/browse/SOLR-15610
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15610.patch
>
>
> JSON Formatted logging is becoming wide spread enough that it seems like we should support it as an option in Solr.
> Assuming we upgrade to log4j >= 2.14.0 (SOLR-15609) then this becomes _possible_ for people to do by:
> # downloading the {{log4j-layout-template-json.jar}} that corresponds with the lof4j version used by their solr version
> # include the {{log4j-layout-template-json.jar}} in the (jetty) classpath via {{SOLR_OPTS}} (can't be loaded as a solr plugin because it needs to be used on startup)
> # specify their own {{LOG4J_PROPS}} file that configures log4j to use a {{JsonTemplateLayout}}
> ..but steps #1 and #2 are a bit hairy. Particularly step #1 as it means every time users upgrade solr they have to pay careful attention to if/when the log4j deps change.
> ----
> I would like to propose that we make this easier, by adding {{log4j-layout-template-json}} as a dependency for the "server" module, so that it is available out of the box when running solr – that way JSON logging can be enabled easily with a simple {{LOG4J_PROPS}} change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org