You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by mh...@apache.org on 2014/07/21 20:14:15 UTC
[7/7] git commit: adding clarity to BaseSorterTestCase.cs
adding clarity to BaseSorterTestCase.cs
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/2cc449a8
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/2cc449a8
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/2cc449a8
Branch: refs/heads/pcl
Commit: 2cc449a80991d683eb57b1bef0bb1cdd512253a1
Parents: cf6d5ef
Author: Michael Herndon <mh...@michaelherndon.com>
Authored: Mon Jul 21 14:10:17 2014 -0400
Committer: Michael Herndon <mh...@michaelherndon.com>
Committed: Mon Jul 21 14:10:17 2014 -0400
----------------------------------------------------------------------
test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucenenet/blob/2cc449a8/test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs
----------------------------------------------------------------------
diff --git a/test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs b/test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs
index 5c7f1ba..0b41443 100644
--- a/test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs
+++ b/test/Lucene.Net.Core.Tests/Util/BaseSorterTestCase.cs
@@ -176,16 +176,18 @@ namespace Lucene.Net.Util
/// <summary>
/// TODO: figure out the differences between the Java Version and .NET
///
- /// Porting the logic as it currently causes the sort to randomly fail.
+ /// Porting the logic as it currently is causes the oridinal position to mismatch and randomly fail
+ /// when the same value is generated for Entry.
///
- /// For instance, Entry only sorts by the VALUE. If you have multiple entries
+ /// Entry only sorts by the VALUE. If you have multiple entries
/// with the same value like in RANDOM_LOW_CARDINALITY, then the sort can have the ordinal position out
/// of order.
///
- /// If you don't constrain, the random.Next() to have a minValue of 1, then zero could be added to the previous value
- /// causing the the value to appear multiple times with different ordinal positions causing the test to fail.
+ /// This could be caused by the differences in implementation of Array.Sort, the Java version of Array.sort
+ /// and the SortRange impelementation.
///
- /// This could be caused by the differences in implementation of Array.Sort.
+ /// To work around this for the short term, the minValue is currently constrained to have a minValue of 1 and
+ /// RANDOM_LOW_CARDINALITY strategy currently omits checking for matching ordinal positions.
/// </summary>
internal protected class Strategy
{