[GitHub] [incubator-devlake] hezyin commented on a diff in pull request #2600: [FIX]: Fixes for k8-deploy.

[GitBox <gi...@apache.org>]

hezyin commented on code in PR #2600:
URL: https://github.com/apache/incubator-devlake/pull/2600#discussion_r929515517


##########
k8s-deploy.yaml:
##########
@@ -12,8 +12,8 @@
 #    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #    See the License for the specific language governing permissions and
 #    limitations under the License.
-  

Review Comment:
   Indeed a bug, thanks for catching this.



##########
k8s-deploy.yaml:
##########
@@ -152,7 +152,7 @@ spec:
         - name: config-ui
           image: mericodev/config-ui:latest
           ports:
-            - containerPort: 4000
+            - containerPort: 30004

Review Comment:
   This container does listen on port 4000. And this `containerPort` value should match with `config-ui` service's `targetPort`, which is also 4000. So we don't want to change this.



##########
k8s-deploy.yaml:
##########
@@ -206,7 +206,7 @@ spec:
             - containerPort: 8080
           env:
             - name: DB_URL
-              value: 'mysql://merico:merico@mysql:3306/lake?charset=utf8mb4&parseTime=True'
+              value: "merico:merico@tcp(mysql:3306)/lake?charset=utf8mb4&parseTime=True"

Review Comment:
   The error you encountered earlier was due to using an old image. The new image that we switched to (v0.12.0-beta3) during our call would take the `mysql://` connection string without issue. Do you think you could try the original connection string with the new image again and let us know if the issue persists?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org