[jira] [Closed] (DOXIA-522) Make snippet macro less permissive of issues

["Robert Scholte (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DOXIA-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed DOXIA-522.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8

#1 and #2 fixed in [rev.1745090|http://svn.apache.org/viewvc?rev=1745090&view=rev]
Patch has been changed slightly. I've changed the default value of ignoreDownloadError to true for backwards compatibility (other projects started to fail due to the original patch)
Thanks for contributing!

> Make snippet macro less permissive of issues
> --------------------------------------------
>
>                 Key: DOXIA-522
>                 URL: https://issues.apache.org/jira/browse/DOXIA-522
>             Project: Maven Doxia
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.6
>            Reporter: James Agnew
>            Assignee: Robert Scholte
>             Fix For: 1.8
>
>         Attachments: diff.txt
>
>
> The attached patch contains several improvements to the snippet macro:
> 1. Make the ignoreDownloadError parameter actually work (it is read, but doesn't actually do anything in the current version)
> 2. Fail if a named snippet is used, but either a START or END for that specific name can't be found (currently nothing is included if the start isn't found, and the whole rest of the source file is included if the end can't be found)
> 3. Don't match named snippets if the desired name is a substring of the found name (e.g. if a source contains "START fooBar" followed by "START foo", including snippet "foo" currently actually matches the one named "fooBar")
> Unit tests are included.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)