You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "bkyryliuk (via GitHub)" <gi...@apache.org> on 2023/08/16 16:05:30 UTC

[GitHub] [superset] bkyryliuk commented on a diff in pull request #24984: fix(hive): Remove unused async arg from execute query func to get hive connector working

bkyryliuk commented on code in PR #24984:
URL: https://github.com/apache/superset/pull/24984#discussion_r1296134942


##########
superset/db_engine_specs/hive.py:
##########
@@ -542,11 +542,9 @@ def update_impersonation_config(
             connect_args["configuration"] = configuration
 
     @staticmethod
-    def execute(  # type: ignore
-        cursor, query: str, async_: bool = False
-    ):  # pylint: disable=arguments-differ
-        kwargs = {"async": async_}
-        cursor.execute(query, **kwargs)
+    def execute(cursor, query: str):

Review Comment:
   I've seen a similar issue for databricks, but not hive though.
   @alldoami  - it would be useful to replicate the bug in the test, as I recall we have presto & hive running in the CI.
   
   The issue with `async` - is that it is a reserved word in python:
   ```In Python 3.7 async became a keyword; you can use async_ instead:```
   
   https://github.com/dropbox/PyHive/blob/d4ae481675ac5588ba9101596fa26f22ef0e77c4/README.rst#L55



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org