You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2014/07/22 02:33:20 UTC
Re: Review Request 23749: Missing Apache headers for stout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 22, 2014, 12:33 a.m.)
Review request for mesos and Benjamin Hindman.
Summary (updated)
-----------------
Missing Apache headers for stout
Repository: mesos-git
Description
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to mesos/support the script I use to make this patch.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74
3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3
3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278
3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c
3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15
3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1
3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb
3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e
3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22
3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185
3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd
3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review91001
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23749]
All tests passed.
- Mesos ReviewBot
On July 8, 2015, 7:17 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 7:17 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 0c315f7
> src/files/files.cpp 3a62ee7
> src/hdfs/hdfs.hpp cba386a
> src/slave/state.cpp fab47a7
> src/state/in_memory.hpp 2040618
> src/state/in_memory.cpp ce04e47
> src/state/leveldb.hpp 53447c6
> src/state/leveldb.cpp 14a1807
> src/state/log.hpp a0ca4f8
> src/state/log.cpp 326f3a7
> src/state/zookeeper.hpp 1a8483d
> src/state/zookeeper.cpp 9151d55
> src/tests/active_user_test_helper.cpp c32d467
> src/zookeeper/authentication.hpp 7b6b767
> src/zookeeper/authentication.cpp ccd6bf7
> src/zookeeper/contender.hpp 6529245
> src/zookeeper/contender.cpp 3255ef0
> src/zookeeper/detector.hpp e41158e
> src/zookeeper/detector.cpp 5305161
> src/zookeeper/group.hpp 9246130
> src/zookeeper/group.cpp 01066e3
> src/zookeeper/watcher.hpp 1e347ed
>
> Diff: https://reviews.apache.org/r/23749/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 8, 2015, 7:17 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Diffs
-----
src/cli/mesos.cpp 0c315f7
src/files/files.cpp 3a62ee7
src/hdfs/hdfs.hpp cba386a
src/slave/state.cpp fab47a7
src/state/in_memory.hpp 2040618
src/state/in_memory.cpp ce04e47
src/state/leveldb.hpp 53447c6
src/state/leveldb.cpp 14a1807
src/state/log.hpp a0ca4f8
src/state/log.cpp 326f3a7
src/state/zookeeper.hpp 1a8483d
src/state/zookeeper.cpp 9151d55
src/tests/active_user_test_helper.cpp c32d467
src/zookeeper/authentication.hpp 7b6b767
src/zookeeper/authentication.cpp ccd6bf7
src/zookeeper/contender.hpp 6529245
src/zookeeper/contender.cpp 3255ef0
src/zookeeper/detector.hpp e41158e
src/zookeeper/detector.cpp 5305161
src/zookeeper/group.hpp 9246130
src/zookeeper/group.cpp 01066e3
src/zookeeper/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review90964
-----------------------------------------------------------
Bad patch!
Reviews applied: [23784]
Failed command: ./support/apply-review.sh -n -r 23784
Error:
2015-07-08 19:14:12 URL:https://reviews.apache.org/r/23784/diff/raw/ [30874/30874] -> "23784.patch" [1]
Successfully applied: Missing Apache headers for stout
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Review: https://reviews.apache.org/r/23784
Checking 28 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
support/check-apache-header.sh
stout:
3rdparty/libprocess/3rdparty/stout/Makefile.am
3rdparty/libprocess/3rdparty/stout/configure.ac
3rdparty/libprocess/3rdparty/stout/include/Makefile.am
3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/main.cpp
3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp
Failed to commit patch
- Mesos ReviewBot
On July 8, 2015, 6:57 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 6:57 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 0c315f7
> src/files/files.cpp 3a62ee7
> src/hdfs/hdfs.hpp cba386a
> src/slave/state.cpp fab47a7
> src/state/in_memory.hpp 2040618
> src/state/in_memory.cpp ce04e47
> src/state/leveldb.hpp 53447c6
> src/state/leveldb.cpp 14a1807
> src/state/log.hpp a0ca4f8
> src/state/log.cpp 326f3a7
> src/state/zookeeper.hpp 1a8483d
> src/state/zookeeper.cpp 9151d55
> src/tests/active_user_test_helper.cpp c32d467
> src/zookeeper/authentication.hpp 7b6b767
> src/zookeeper/authentication.cpp ccd6bf7
> src/zookeeper/contender.hpp 6529245
> src/zookeeper/contender.cpp 3255ef0
> src/zookeeper/detector.hpp e41158e
> src/zookeeper/detector.cpp 5305161
> src/zookeeper/group.hpp 9246130
> src/zookeeper/group.cpp 01066e3
> src/zookeeper/watcher.hpp 1e347ed
>
> Diff: https://reviews.apache.org/r/23749/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 8, 2015, 6:57 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Diffs
-----
src/cli/mesos.cpp 0c315f7
src/files/files.cpp 3a62ee7
src/hdfs/hdfs.hpp cba386a
src/slave/state.cpp fab47a7
src/state/in_memory.hpp 2040618
src/state/in_memory.cpp ce04e47
src/state/leveldb.hpp 53447c6
src/state/leveldb.cpp 14a1807
src/state/log.hpp a0ca4f8
src/state/log.cpp 326f3a7
src/state/zookeeper.hpp 1a8483d
src/state/zookeeper.cpp 9151d55
src/tests/active_user_test_helper.cpp c32d467
src/zookeeper/authentication.hpp 7b6b767
src/zookeeper/authentication.cpp ccd6bf7
src/zookeeper/contender.hpp 6529245
src/zookeeper/contender.cpp 3255ef0
src/zookeeper/detector.hpp e41158e
src/zookeeper/detector.cpp 5305161
src/zookeeper/group.hpp 9246130
src/zookeeper/group.cpp 01066e3
src/zookeeper/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review90628
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23749]
All tests passed.
- Mesos ReviewBot
On July 6, 2015, 10:33 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 10:33 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 0c315f7
> src/files/files.cpp 3a62ee7
> src/hdfs/hdfs.hpp cba386a
> src/slave/state.cpp fab47a7
> src/state/in_memory.hpp 2040618
> src/state/in_memory.cpp ce04e47
> src/state/leveldb.hpp 53447c6
> src/state/leveldb.cpp 14a1807
> src/state/log.hpp a0ca4f8
> src/state/log.cpp 326f3a7
> src/state/zookeeper.hpp 1a8483d
> src/state/zookeeper.cpp 9151d55
> src/tests/active_user_test_helper.cpp c32d467
> src/zookeeper/authentication.hpp 7b6b767
> src/zookeeper/authentication.cpp ccd6bf7
> src/zookeeper/contender.hpp 6529245
> src/zookeeper/contender.cpp 3255ef0
> src/zookeeper/detector.hpp e41158e
> src/zookeeper/detector.cpp 5305161
> src/zookeeper/group.hpp 9246130
> src/zookeeper/group.cpp 01066e3
> src/zookeeper/watcher.hpp 1e347ed
>
> Diff: https://reviews.apache.org/r/23749/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 6, 2015, 10:33 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Diffs (updated)
-----
src/cli/mesos.cpp 0c315f7
src/files/files.cpp 3a62ee7
src/hdfs/hdfs.hpp cba386a
src/slave/state.cpp fab47a7
src/state/in_memory.hpp 2040618
src/state/in_memory.cpp ce04e47
src/state/leveldb.hpp 53447c6
src/state/leveldb.cpp 14a1807
src/state/log.hpp a0ca4f8
src/state/log.cpp 326f3a7
src/state/zookeeper.hpp 1a8483d
src/state/zookeeper.cpp 9151d55
src/tests/active_user_test_helper.cpp c32d467
src/zookeeper/authentication.hpp 7b6b767
src/zookeeper/authentication.cpp ccd6bf7
src/zookeeper/contender.hpp 6529245
src/zookeeper/contender.cpp 3255ef0
src/zookeeper/detector.hpp e41158e
src/zookeeper/detector.cpp 5305161
src/zookeeper/group.hpp 9246130
src/zookeeper/group.cpp 01066e3
src/zookeeper/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 6, 2015, 10:25 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Diffs (updated)
-----
src/cli/mesos.cpp 0c315f7
src/files/files.cpp 3a62ee7
src/hdfs/hdfs.hpp cba386a
src/slave/state.cpp fab47a7
src/state/in_memory.hpp 2040618
src/state/in_memory.cpp ce04e47
src/state/leveldb.hpp 53447c6
src/state/leveldb.cpp 14a1807
src/state/log.hpp a0ca4f8
src/state/log.cpp 326f3a7
src/state/zookeeper.hpp 1a8483d
src/state/zookeeper.cpp 9151d55
src/tests/active_user_test_helper.cpp c32d467
src/zookeeper/authentication.hpp 7b6b767
src/zookeeper/authentication.cpp ccd6bf7
src/zookeeper/contender.hpp 6529245
src/zookeeper/contender.cpp 3255ef0
src/zookeeper/detector.hpp e41158e
src/zookeeper/detector.cpp 5305161
src/zookeeper/group.hpp 9246130
src/zookeeper/group.cpp 01066e3
src/zookeeper/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 23749: Missing Apache headers for mesos
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------
(Updated July 22, 2014, 10:34 p.m.)
Review request for mesos and Benjamin Hindman.
Summary (updated)
-----------------
Missing Apache headers for mesos
Repository: mesos-git
Description (updated)
-------
Adding missing Apache licence headers on .cpp, .hpp and Makefiles
Diffs (updated)
-----
src/cli/mesos.cpp 171a707
src/common/http.cpp e81a7ad
src/common/thread.hpp 7e48724
src/files/files.cpp 3dacc66
src/hdfs/hdfs.hpp bbfedde
src/java/jni/org_apache_mesos_state_AbstractState.cpp 1accc8a
src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309
src/java/jni/org_apache_mesos_state_Variable.cpp 4d840ce
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685
src/jvm/java/io.hpp fcb1409
src/jvm/java/lang.hpp 6fc6566
src/jvm/java/net.hpp cabb3e5
src/jvm/jvm.hpp 2f2e1d1
src/jvm/jvm.cpp d33a655
src/jvm/org/apache/log4j.hpp 0913a6b
src/jvm/org/apache/log4j.cpp 105629c
src/jvm/org/apache/zookeeper.hpp 0797d47
src/jvm/org/apache/zookeeper.cpp 192b647
src/sasl/auxprop.cpp 6de1222
src/slave/state.cpp 87e9eb9
src/state/in_memory.hpp 2040618
src/state/in_memory.cpp ce04e47
src/state/leveldb.hpp 53447c6
src/state/leveldb.cpp 4303df3
src/state/log.hpp 6bd054f
src/state/log.cpp fd8b28a
src/state/zookeeper.hpp 1a8483d
src/state/zookeeper.cpp d355bd7
src/zookeeper/authentication.hpp 7b6b767
src/zookeeper/authentication.cpp ccd6bf7
src/zookeeper/contender.hpp 6529245
src/zookeeper/contender.cpp 55cb7a1
src/zookeeper/detector.hpp e41158e
src/zookeeper/detector.cpp 5305161
src/zookeeper/group.hpp 16f9b7b
src/zookeeper/group.cpp 58491c0
src/zookeeper/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
-------
Thanks,
Isabel Jimenez