[GitHub] markusthoemmes commented on a change in pull request #4185: recreate http client on resume()

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4185: recreate http client on resume()
URL: https://github.com/apache/incubator-openwhisk/pull/4185#discussion_r242426665
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/Container.scala
 ##########
 @@ -73,6 +73,10 @@ trait Container {
   /** HTTP connection to the container, will be lazily established by callContainer */
   protected var httpConnection: Option[ContainerClient] = None
 
+  /** maxConcurrent+timeout are cached during first init, so that resuming connections can reference */
+  protected var containerHttpMaxConcurrent: Int = 1
+  protected var containerHttpTimeout: FiniteDuration = 60.seconds
 
 Review comment:
   I know this was the case before, but we should add a comment to the trait stating that it's not thread-safe and the caller MUST ensure synchronization (which we do by using an actor)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services