[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18140#discussion_r119022422
  
    --- Diff: R/pkg/R/mllib_regression.R ---
    @@ -110,7 +125,8 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj"))
     #' @seealso \link{glm}, \link{read.ml}
     setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"),
               function(data, formula, family = gaussian, tol = 1e-6, maxIter = 25, weightCol = NULL,
    -                   regParam = 0.0, var.power = 0.0, link.power = 1.0 - var.power) {
    +                   regParam = 0.0, var.power = 0.0, link.power = 1.0 - var.power,
    +                   stringIndexerOrderType = "frequencyDesc") {
    --- End diff --
    
    given we need to spell it out, I'm wondering it it would be better to check the `stringIndexerOrderType` parameter to match on of the supported options in R?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org