You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/03/02 15:20:07 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5452: fix: build union schema with child has same column name but qualifier…

jackwener commented on code in PR #5452:
URL: https://github.com/apache/arrow-datafusion/pull/5452#discussion_r1123270256


##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1101,7 +1101,7 @@ pub fn union(left_plan: LogicalPlan, right_plan: LogicalPlan) -> Result<LogicalP
                     })?;
 
             Ok(DFField::new(
-                None,
+                left_field.qualifier().map(|x| &**x),

Review Comment:
   ```suggestion
                   left_field.qualifier().map(|x| x.as_ref()),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org