You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/30 08:42:23 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4301: Move the
comment of the duration into the doc.
wu-sheng opened a new pull request #4301: Move the comment of the duration into the doc.
URL: https://github.com/apache/skywalking/pull/4301
Please answer these questions before submitting pull request
- Why submit this pull request?
Doc improvement.
- Related issues
Resolve #4267 and https://github.com/apache/skywalking/issues/4266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4301: Move the comment
of the duration into the doc.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4301: Move the comment of the duration into the doc.
URL: https://github.com/apache/skywalking/pull/4301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4301: Move the comment
of the duration into the doc.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4301: Move the comment of the duration into the doc.
URL: https://github.com/apache/skywalking/pull/4301#issuecomment-580159514
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=h1) Report
> Merging [#4301](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/17e3fff83a14776c864cd3bc8a1e7c5c62607169?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4301 +/- ##
==========================================
- Coverage 26.88% 26.86% -0.03%
==========================================
Files 1162 1162
Lines 25398 25398
Branches 3627 3627
==========================================
- Hits 6829 6822 -7
- Misses 17964 17971 +7
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `28.73% <0%> (-8.05%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=footer). Last update [17e3fff...78311c3](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4301: Move the
comment of the duration into the doc.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4301: Move the comment of the duration into the doc.
URL: https://github.com/apache/skywalking/pull/4301#issuecomment-580159514
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=h1) Report
> Merging [#4301](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/78311c3b02c989ae4207b90b4c630d9d31d20f9e?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `23.88%`.
[](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4301 +/- ##
==========================================
+ Coverage 26.86% 26.92% +0.06%
==========================================
Files 1162 1168 +6
Lines 25398 25465 +67
Branches 3627 3634 +7
==========================================
+ Hits 6822 6857 +35
- Misses 17971 17999 +28
- Partials 605 609 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ywalking/apm/plugin/avro/ResponderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL1Jlc3BvbmRlckludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [.../skywalking/apm/plugin/avro/SWClientRPCPlugin.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL1NXQ2xpZW50UlBDUGx1Z2luLmphdmE=) | `0% <0%> (ø)` | |
| [.../skywalking/apm/plugin/avro/SWServerRPCPlugin.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL1NXU2VydmVyUlBDUGx1Z2luLmphdmE=) | `0% <0%> (ø)` | |
| [.../apm/plugin/avro/SpecificRequestorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL1NwZWNpZmljUmVxdWVzdG9ySW50ZXJjZXB0b3IuamF2YQ==) | `100% <100%> (ø)` | |
| [...g/apm/plugin/avro/GenericRequestorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL0dlbmVyaWNSZXF1ZXN0b3JJbnRlcmNlcHRvci5qYXZh) | `100% <100%> (ø)` | |
| [...ng/apm/plugin/avro/AbstractRequestInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vYXZyby1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9hdnJvL0Fic3RyYWN0UmVxdWVzdEludGVyY2VwdG9yLmphdmE=) | `15% <15%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/4301/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=footer). Last update [78311c3...ff19ec3](https://codecov.io/gh/apache/skywalking/pull/4301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services