You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2015/09/01 04:31:26 UTC

[GitHub] spark pull request: [SPARK-10377] [SQL] Rename TakeOrderedAndProje...

GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/8545

    [SPARK-10377] [SQL] Rename TakeOrderedAndProject back to TakeOrdered.

    https://issues.apache.org/jira/browse/SPARK-10377
    
    https://github.com/apache/spark/pull/8252#issuecomment-136480957 renames `TakeOrdered` to `TakeOrderedAndProject`, which breaks user code using Spark 1.4 branch. This PR renames this class back to `TakeOrdered`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark SPARK-10377

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8545
    
----
commit 8e659eb53be836434250336ed5025bc34532c1d1
Author: Yin Huai <yh...@databricks.com>
Date:   2015-09-01T02:28:35Z

    Rename TakeOrderedAndProject back to TakeOrdered.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

Posted by frodeso <gi...@git.apache.org>.

Github user frodeso commented on the pull request:

    https://github.com/apache/spark/pull/8545#issuecomment-136813226
  
    @cloud-fan @yhuai  I just did the same and came to the same conclusion. We are not actually involved in the connector, just a user of it so no guarantees though. 
    
    Thanks for the quick response!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

Posted by JoshRosen <gi...@git.apache.org>.

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/8545#issuecomment-136798868
  
    I believe that we've also made other strategy renames in recent patches, including a rename of the join selection strategy (it's no longer called HashJoinStrategy). Does this imply that we need to change that name back as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8545#issuecomment-136557367
  
      [Test build #41851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41851/consoleFull) for   PR 8545 at commit [`8e659eb`](https://github.com/apache/spark/commit/8e659eb53be836434250336ed5025bc34532c1d1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOr...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8545#issuecomment-136585495
  
      [Test build #41851 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41851/consoleFull) for   PR 8545 at commit [`8e659eb`](https://github.com/apache/spark/commit/8e659eb53be836434250336ed5025bc34532c1d1).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org