You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/01/17 04:41:32 UTC
[GitHub] [fluo-website] jkosh44 opened a new pull request #186: Add link to
fluo-recipes 1.2 docs
jkosh44 opened a new pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] keith-turner commented on a change in pull request
#186: Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r369077310
##########
File path: docs/index.md
##########
@@ -16,6 +16,7 @@ redirect_from:
### Apache Fluo Recipes documentation
+* [1.2][recipes-1.2] - March 1, 2018
Review comment:
```suggestion
* [1.2][recipes-1.2] - March 6, 2018
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] ctubbsii commented on a change in pull request #186:
Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r367786236
##########
File path: docs/index.md
##########
@@ -16,6 +16,7 @@ redirect_from:
### Apache Fluo Recipes documentation
+* [1.2][recipes-1.2] - March 1, 2018
Review comment:
The official date for the release is technically the date of distribution, which is effectively the date it was uploaded to the SVN-dist mirror system. That date is `March 6, 2018`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] keith-turner commented on a change in pull request
#186: Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r369074438
##########
File path: docs/index.md
##########
@@ -26,5 +27,6 @@ Documentation for releases before joining Apache have been [archived](archive).
[fluo-1.2]: /docs/fluo/1.2/
[fluo-1.1]: /docs/fluo/1.1.0-incubating/
[fluo-1.0]: /docs/fluo/1.0.0-incubating/
+[recipes-1.2]: /docs/fluo-recipes/1.2/
Review comment:
The page https://fluo.apache.org/docs/fluo-recipes/1.2 definitely exists. Its not at that location in source though, in source its in the `_recipes-1-2` dir and I think something in `_config.yml` maps `/docs/fluo-recipes/1.2` to `_recipes-1-2`. I think this change is appropriate given the docs already exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] jkosh44 commented on a change in pull request #186:
Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r368242544
##########
File path: docs/index.md
##########
@@ -26,5 +27,6 @@ Documentation for releases before joining Apache have been [archived](archive).
[fluo-1.2]: /docs/fluo/1.2/
[fluo-1.1]: /docs/fluo/1.1.0-incubating/
[fluo-1.0]: /docs/fluo/1.0.0-incubating/
+[recipes-1.2]: /docs/fluo-recipes/1.2/
Review comment:
To be honest I'm not as familiar with the website code as I'd like to be. The reason for this pull request was that I was on this page: [https://fluo.apache.org//docs/](https://fluo.apache.org//docs/). I clicked the most recent version of the fluo-recipe docs listed which is 1.1.0-incubating. That brought me here: [https://fluo.apache.org/docs/fluo-recipes/1.1.0-incubating/](https://fluo.apache.org/docs/fluo-recipes/1.1.0-incubating/). At the top of that page there is a banner that says "These docs are for Fluo Recipes 1.1.0-incubating which is an old version! Check out the latest docs!" The banner provides a link here: [https://fluo.apache.org//docs/fluo-recipes/1.2/getting-started/overview](https://fluo.apache.org//docs/fluo-recipes/1.2/getting-started/overview), which seems to be the 1.2 fluo-recipe docs.
It seemed like a link to [https://fluo.apache.org//docs/fluo-recipes/1.2/getting-started/overview](https://fluo.apache.org//docs/fluo-recipes/1.2/getting-started/overview) should be added to [https://fluo.apache.org//docs/](https://fluo.apache.org//docs/), but again I'm not as familiar with the website code as I'd like to be so I'm not sure if that's accurate or what the best way of accomplishing that is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] keith-turner commented on a change in pull request
#186: Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r368166978
##########
File path: docs/index.md
##########
@@ -26,5 +27,6 @@ Documentation for releases before joining Apache have been [archived](archive).
[fluo-1.2]: /docs/fluo/1.2/
[fluo-1.1]: /docs/fluo/1.1.0-incubating/
[fluo-1.0]: /docs/fluo/1.0.0-incubating/
+[recipes-1.2]: /docs/fluo-recipes/1.2/
Review comment:
Next week I am going to look into the docs for version 1.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] ctubbsii commented on a change in pull request #186:
Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r369168563
##########
File path: docs/index.md
##########
@@ -26,5 +27,6 @@ Documentation for releases before joining Apache have been [archived](archive).
[fluo-1.2]: /docs/fluo/1.2/
[fluo-1.1]: /docs/fluo/1.1.0-incubating/
[fluo-1.0]: /docs/fluo/1.0.0-incubating/
+[recipes-1.2]: /docs/fluo-recipes/1.2/
Review comment:
Oh, I see. In that case, then :+1: for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] jkosh44 commented on issue #186: Add link to
fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on issue #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#issuecomment-576992474
I fixed the date, is this good to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] jkosh44 commented on a change in pull request #186:
Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r367766954
##########
File path: docs/index.md
##########
@@ -16,6 +16,7 @@ redirect_from:
### Apache Fluo Recipes documentation
+* [1.2][recipes-1.2] - March 1, 2018
Review comment:
Can someone validate this date? I got it from the 1.2 tag in the fluo-recipes repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] ctubbsii commented on a change in pull request #186:
Add link to fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186#discussion_r367792411
##########
File path: docs/index.md
##########
@@ -26,5 +27,6 @@ Documentation for releases before joining Apache have been [archived](archive).
[fluo-1.2]: /docs/fluo/1.2/
[fluo-1.1]: /docs/fluo/1.1.0-incubating/
[fluo-1.0]: /docs/fluo/1.0.0-incubating/
+[recipes-1.2]: /docs/fluo-recipes/1.2/
Review comment:
This page doesn't exist yet. I'm not sure if anything has changed since 1.1, but we probably don't want to get into the habit of copy/pasting unchanged documentation to get the URLs to work out. I'm not sure what the best thing to do here is. IMO, ideally, we'd have a single set of 1.x documentation, and we'd just annotate a "since 1.1", "since 1.2", etc., as appropriate. I think that's the direction Accumulo's website is going for Accumulo 2.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-website] jkosh44 merged pull request #186: Add link to
fluo-recipes 1.2 docs
Posted by GitBox <gi...@apache.org>.
jkosh44 merged pull request #186: Add link to fluo-recipes 1.2 docs
URL: https://github.com/apache/fluo-website/pull/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services