You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/03/23 15:57:12 UTC
[GitHub] brooklyn-server pull request: Don't skip tests jar generation duri...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/77
Don't skip tests jar generation during tests
When passed `-PIntegration` tests jars are not getting built on purpose. This causes build failures down the road where the missing tests-jar is a dependency in another module.
Initially introduced in https://github.com/apache/incubator-brooklyn/commit
/dbda0be45531ba20085c1d082430b44aaca55231?w=1 without any details on why it's needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server fix/integration-tests-jar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 8f7d3e63299d60bffc17a3a6dc94bd361fa49e2d
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-03-23T13:54:05Z
Don't skip tests jar generation during tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Don't skip tests jar generation duri...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/77#issuecomment-200403209
Interesting, but unrelated failure:
```
Tests run: 1663, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 270.277 sec <<< FAILURE! - in TestSuite
testConcurrentCallToManageForbidden(org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest) Time elapsed: 20.044 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest$11.doBuild(ApplicationBuilderOverridingTest.java:205)
at org.apache.brooklyn.core.entity.factory.ApplicationBuilder.manage(ApplicationBuilder.java:219)
at org.apache.brooklyn.core.entity.proxying.ApplicationBuilderOverridingTest.testConcurrentCallToManageForbidden(ApplicationBuilderOverridingTest.java:230)
```
/cc @aledsage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Don't skip tests jar generation duri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Don't skip tests jar generation duri...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/77#issuecomment-200803214
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---