Re: [PR] Enhance rebalance progress stats [pinot]

["somandal (via GitHub)" <gi...@apache.org>]

somandal commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2021934047


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -567,6 +577,15 @@ private RebalanceResult doRebalance(TableConfig tableConfig, RebalanceConfig reb
               + "added/removed for each instance: {}", rebalanceJobId, tableNameWithType,
           SegmentAssignmentUtils.getNumSegmentsToMovePerInstance(currentAssignment, nextAssignment));
 
+      // Record change of current ideal state and the next assignment
+      _tableRebalanceObserver.onTrigger(TableRebalanceObserver.Trigger.NEXT_ASSINGMENT_CALCULATION_TRIGGER,
+          currentAssignment, nextAssignment, rebalanceContext);
+      if (_tableRebalanceObserver.isStopped()) {

Review Comment:
   One example would be if someone calls the CANCEL API for rebalance to cancel the rebalance job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org