You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Nico Krijnen (JIRA)" <my...@incubator.apache.org> on 2005/10/19 11:04:45 UTC
[jira] Created: (MYFACES-718) ExternalContext.redirect does not call responseComplete()
ExternalContext.redirect does not call responseComplete()
---------------------------------------------------------
Key: MYFACES-718
URL: http://issues.apache.org/jira/browse/MYFACES-718
Project: MyFaces
Type: Bug
Components: Implementation
Versions: 1.1.0, 1.0.9m9, 1.1.1, Nightly
Reporter: Nico Krijnen
Priority: Minor
It seems that the redirect method in org.apache.myfaces.context.servlet.ServletExternalContextImpl does not call responseComplete() as it should. The official API documentation states:
Redirect a request to the specified URL, and cause the responseComplete() method to be called on the FacesContext instance for the current request.
See: http://java.sun.com/j2ee/javaserverfaces/1.1/docs/api/javax/faces/context/ExternalContext.html#redirect(java.lang.String)
When I look at the redirect method in the current trunk it does not call responseComplete()
http://svn.apache.org/repos/asf/myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
The same goes for the Portlet version of the ExternalContext implementation.
I did a quick search and found the same issue reported in the user list two and a half months ago by Richard Wallace (http://www.mail-archive.com/users@myfaces.apache.org/msg06486.html). It does not seem to be reported in JIRA, so I added it here.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-718) ExternalContext.redirect does not call responseComplete()
Posted by "Mathias Broekelmann (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-718?page=all ]
Mathias Broekelmann closed MYFACES-718:
---------------------------------------
Fix Version: Nightly
Resolution: Fixed
the myfaces navigation handler called the responseComplete() method so this should only be an issue if a custom navigation handler is used. I moved this call to the external context as specified in the spec. Thanks Nico Krijnen
> ExternalContext.redirect does not call responseComplete()
> ---------------------------------------------------------
>
> Key: MYFACES-718
> URL: http://issues.apache.org/jira/browse/MYFACES-718
> Project: MyFaces
> Type: Bug
> Components: Implementation
> Versions: 1.0.9m9, 1.1.0, Nightly, 1.1.1
> Reporter: Nico Krijnen
> Assignee: Mathias Broekelmann
> Priority: Minor
> Fix For: Nightly
>
> It seems that the redirect method in org.apache.myfaces.context.servlet.ServletExternalContextImpl does not call responseComplete() as it should. The official API documentation states:
> Redirect a request to the specified URL, and cause the responseComplete() method to be called on the FacesContext instance for the current request.
> See: http://java.sun.com/j2ee/javaserverfaces/1.1/docs/api/javax/faces/context/ExternalContext.html#redirect(java.lang.String)
> When I look at the redirect method in the current trunk it does not call responseComplete()
> http://svn.apache.org/repos/asf/myfaces/impl/trunk/src/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
> The same goes for the Portlet version of the ExternalContext implementation.
> I did a quick search and found the same issue reported in the user list two and a half months ago by Richard Wallace (http://www.mail-archive.com/users@myfaces.apache.org/msg06486.html). It does not seem to be reported in JIRA, so I added it here.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira