[GitHub] [arrow-datafusion] houqp opened a new issue #593: logical plan builder from method should take owned value as input

[GitBox <gi...@apache.org>]

houqp opened a new issue #593:
URL: https://github.com/apache/arrow-datafusion/issues/593


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   ```
   pub fn from(plan: &LogicalPlan) -> Self {
       Self { plan: plan.clone() }
   ```
   
   The from method takes a LogicalPlan reference, then does clone internally.
   
   **Describe the solution you'd like**
   
   It would be better to take an owned value and let the caller handle the clone if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #593: logical plan builder from method should take owned value as input

[GitBox <gi...@apache.org>]

alamb closed issue #593:
URL: https://github.com/apache/arrow-datafusion/issues/593


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org