You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/28 23:23:52 UTC
[GitHub] [spark] jsoref opened a new pull request #30530: Spelling bin core docs external mllib repl
jsoref opened a new pull request #30530:
URL: https://github.com/apache/spark/pull/30530
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR intends to fix typos in the sub-modules:
* `bin`
* `core`
* `docs`
* `external`
* `mllib`
* `repl`
Split per @srowen https://github.com/apache/spark/pull/30323#issuecomment-728981618
NOTE: The misspellings have been reported at https://github.com/jsoref/spark/commit/706a726f87a0bbf5e31467fae9015218773db85b#commitcomment-44064356
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Misspelled words make it harder to read / understand content.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
There are various fixes to documentation, etc...
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No testing was performed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk edited a comment on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
kiszk edited a comment on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735404355
Could you please address the following typos, too?
`docs/configuration.md`
excluded -> excluded
`docs/graphx-programming-guide.md`
an \`VertexRDD -> a \`VertexRDD (2 places)
`docs/mllib-clustering.md`
an \`JavaRDD` -> a \`JavaRDD`
`docs/mllib-data-types.md`
an CoordinateMatrix -> a CoordinateMatrix
`docs/running-on-kubernetes.md` and `docs/running-on-yarn.md`
propogate -> propagate (2 places)
~`docs/sql-ref-syntax-qry-select-groupby.md`
column -> column (3 places)~
`docs/sql-ref-syntax-qry-select-lateral-view.md`
tabelName -> tableName (3 places)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jsoref commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
jsoref commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735438004
@kiszk: done (not quite sure how I missed `tabel`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735545329
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735467276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #30530:
URL: https://github.com/apache/spark/pull/30530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735502250
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735404355
Could you please address the following typos, too?
`docs/configuration.md`
excluded -> excluded
`docs/graphx-programming-guide.md`
an \`VertexRDD -> a \`VertexRDD (2 places)
`docs/mllib-clustering.md`
an \`JavaRDD` -> a \`JavaRDD`
`docs/mllib-data-types.md`
an CoordinateMatrix -> a CoordinateMatrix
`docs/running-on-kubernetes.md` and `docs/running-on-yarn.md`
propogate -> propagate (2 places)
`docs/sql-ref-syntax-qry-select-groupby.md`
column -> column (3 places)
`docs/sql-ref-syntax-qry-select-lateral-view.md`
tabelName -> tableName (3 places)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735304254
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735439377
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735449538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30530: Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735304254
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735463759
**[Test build #131934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131934/testReport)** for PR 30530 at commit [`295f588`](https://github.com/apache/spark/commit/295f588dc2e91862ef11f439f4d069003f487a9e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735449538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735441895
**[Test build #131934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131934/testReport)** for PR 30530 at commit [`295f588`](https://github.com/apache/spark/commit/295f588dc2e91862ef11f439f4d069003f487a9e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735441895
**[Test build #131934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131934/testReport)** for PR 30530 at commit [`295f588`](https://github.com/apache/spark/commit/295f588dc2e91862ef11f439f4d069003f487a9e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30530: [MINOR] Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30530:
URL: https://github.com/apache/spark/pull/30530#issuecomment-735467276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #30530: Spelling bin core docs external mllib repl
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #30530:
URL: https://github.com/apache/spark/pull/30530#discussion_r532124096
##########
File path: docs/sql-migration-guide.md
##########
@@ -333,7 +333,7 @@ license: |
</tr>
</table>
- - Since Spark 2.4, when there is a struct field in front of the IN operator before a subquery, the inner query must contain a struct field as well. In previous versions, instead, the fields of the struct were compared to the output of the inner query. Eg. if `a` is a `struct(a string, b int)`, in Spark 2.4 `a in (select (1 as a, 'a' as b) from range(1))` is a valid query, while `a in (select 1, 'a' from range(1))` is not. In previous version it was the opposite.
+ - Since Spark 2.4, when there is a struct field in front of the IN operator before a subquery, the inner query must contain a struct field as well. In previous versions, instead, the fields of the struct were compared to the output of the inner query. E.g. if `a` is a `struct(a string, b int)`, in Spark 2.4 `a in (select (1 as a, 'a' as b) from range(1))` is a valid query, while `a in (select 1, 'a' from range(1))` is not. In previous version it was the opposite.
Review comment:
Nit, for if we need to fix anything else: "E.g." probably should not begin a sentence. "For example," is better
##########
File path: docs/sql-migration-guide.md
##########
@@ -532,11 +532,11 @@ license: |
- Since Spark 2.3, by default arithmetic operations between decimals return a rounded value if an exact representation is not possible (instead of returning NULL). This is compliant with SQL ANSI 2011 specification and Hive's new behavior introduced in Hive 2.2 (HIVE-15331). This involves the following changes
- - The rules to determine the result type of an arithmetic operation have been updated. In particular, if the precision / scale needed are out of the range of available values, the scale is reduced up to 6, in order to prevent the truncation of the integer part of the decimals. All the arithmetic operations are affected by the change, ie. addition (`+`), subtraction (`-`), multiplication (`*`), division (`/`), remainder (`%`) and positive module (`pmod`).
+ - The rules to determine the result type of an arithmetic operation have been updated. In particular, if the precision / scale needed are out of the range of available values, the scale is reduced up to 6, in order to prevent the truncation of the integer part of the decimals. All the arithmetic operations are affected by the change, i.e. addition (`+`), subtraction (`-`), multiplication (`*`), division (`/`), remainder (`%`) and positive module (`pmod`).
Review comment:
Also let's fix "positive module" to "positive modulus"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org