You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/30 11:13:16 UTC

[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #5007: Fixes Issue3265

menghaoranss opened a new pull request #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007
 
 
   Fixes #3265.
   
   Changes proposed in this pull request:
   - support edit config and registry center
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #5007: Fixes Issue3265

Posted by GitBox <gi...@apache.org>.

kimmking commented on a change in pull request #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007#discussion_r400605593
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/CenterConfigServiceImpl.java
 ##########
 @@ -102,6 +103,28 @@ public CenterConfigs loadAll(String orchestrationType) {
         return result;
     }
     
+    @Override
+    public void update(CenterConfigDTO config) {
+        CenterConfigs configs = loadAll();
+        if (!config.getPrimaryName().equals(config.getName())) {
+            CenterConfig existedConfig = find(config.getName(), config.getOrchestrationType(), configs);
+            if (null != existedConfig) {
+                throw new ShardingSphereUIException(ShardingSphereUIException.SERVER_ERROR, "Center already existed!");
 
 Review comment:
   Add name to messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5007: Fixes Issue3265

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007#issuecomment-605975180
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=h1) Report
   > Merging [#5007](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/2048b38bc794d95f3d6f3c532381f3543cf31335&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5007      +/-   ##
   ============================================
   + Coverage     53.70%   53.82%   +0.12%     
   + Complexity      442      441       -1     
   ============================================
     Files          1143     1139       -4     
     Lines         20515    20474      -41     
     Branches       3745     3741       -4     
   ============================================
   + Hits          11017    11021       +4     
   + Misses         8797     8748      -49     
   - Partials        701      705       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...shardingscaling/core/metadata/MetaDataManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL01ldGFEYXRhTWFuYWdlci5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rdingscaling/postgresql/wal/WalEventConverter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL3dhbC9XYWxFdmVudENvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ngscaling/core/metadata/column/ColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL2NvbHVtbi9Db2x1bW5NZXRhRGF0YS5qYXZh) | | | |
   | [...ing/core/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL2NvbHVtbi9Db2x1bW5NZXRhRGF0YUxvYWRlci5qYXZh) | | | |
   | [...dingscaling/core/metadata/table/TableMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL3RhYmxlL1RhYmxlTWV0YURhdGEuamF2YQ==) | | | |
   | [...aling/core/metadata/table/TableMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL3RhYmxlL1RhYmxlTWV0YURhdGFMb2FkZXIuamF2YQ==) | | | |
   | [...ql/parser/binder/metadata/table/TableMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvdGFibGUvVGFibGVNZXRhRGF0YS5qYXZh) | `89.28% <0.00%> (+10.71%)` | `0.00% <0.00%> (ø%)` | |
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `68.08% <0.00%> (+68.08%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=footer). Last update [2048b38...78efcb0](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5007: Fixes Issue3265

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] menghaoranss commented on a change in pull request #5007: Fixes Issue3265

Posted by GitBox <gi...@apache.org>.

menghaoranss commented on a change in pull request #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007#discussion_r400611088
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/CenterConfigServiceImpl.java
 ##########
 @@ -102,6 +103,28 @@ public CenterConfigs loadAll(String orchestrationType) {
         return result;
     }
     
+    @Override
+    public void update(CenterConfigDTO config) {
+        CenterConfigs configs = loadAll();
+        if (!config.getPrimaryName().equals(config.getName())) {
+            CenterConfig existedConfig = find(config.getName(), config.getOrchestrationType(), configs);
+            if (null != existedConfig) {
+                throw new ShardingSphereUIException(ShardingSphereUIException.SERVER_ERROR, "Center already existed!");
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5007: Fixes Issue3265

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #5007: Fixes Issue3265
URL: https://github.com/apache/incubator-shardingsphere/pull/5007#issuecomment-605979700
 
 
   ## Pull Request Test Coverage Report for [Build 10707](https://coveralls.io/builds/29708389)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.331%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29708389/badge)](https://coveralls.io/builds/29708389) |
   | :-- | --: |
   | Change from base [Build 10705](https://coveralls.io/builds/29707536): |  0.0% |
   | Covered Lines: | 11738 |
   | Relevant Lines: | 20474 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services