You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/15 07:30:25 UTC

[GitHub] [flink] tony810430 opened a new pull request #16162: [hotfix][docs] fix img links and previous docs link

tony810430 opened a new pull request #16162:
URL: https://github.com/apache/flink/pull/16162


   ## What is the purpose of the change
   
   to fix some issues for docs, such as image link error and missing 1.13 doc link
   
   ## Brief change log
   
   - fix image link error
   - add v1.13 doc link
   
   ## Verifying this change
   
   check the change by building docs locally. 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-861258965


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 00f3ae0490201f6a9dc178ce5d946aa6050a7a6c (Sat Aug 28 12:19:04 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-861284811


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 00f3ae0490201f6a9dc178ce5d946aa6050a7a6c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tony810430 commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
tony810430 commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-864703592


   Hi @Myasuka 
   
   Thanks for the reviewing. I will remember to create a JIRA ticket next time.
   besides, I think [FLINK-23012](https://issues.apache.org/jira/browse/FLINK-23012) is also addressed in this PR. could you help to close this issue as well? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-861258965


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 00f3ae0490201f6a9dc178ce5d946aa6050a7a6c (Tue Jun 15 07:33:34 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-861284811


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18988",
       "triggerID" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 00f3ae0490201f6a9dc178ce5d946aa6050a7a6c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18988) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka merged pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #16162:
URL: https://github.com/apache/flink/pull/16162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-861284811


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18988",
       "triggerID" : "00f3ae0490201f6a9dc178ce5d946aa6050a7a6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 00f3ae0490201f6a9dc178ce5d946aa6050a7a6c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18988) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #16162: [hotfix][docs] fix img links and previous docs link

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #16162:
URL: https://github.com/apache/flink/pull/16162#issuecomment-864707829


   I have closed FLINK-23012 and also pick your PR to release-1.13 branch with removal of adding previous docs link in 3964761b80d2dce532d04704d1a3f4b097a8c5eb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org