You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/05 19:53:53 UTC
[GitHub] [superset] eschutho opened a new pull request #13488: allow option to generate new query
eschutho opened a new pull request #13488:
URL: https://github.com/apache/superset/pull/13488
### SUMMARY
We are seeing some errors of runQuery being instantiated with a query that has already been created server-side, resulting in a duplicate client_id error. The second api call happens exactly one minute from the first. I haven't been able to recreate the cause, but I looked for instances where we were possibly dispatching `runQuery` with an existing query. I created a new action called `reRunQuery` that removes the id and generates a new one, and then dispatches `runQuery`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
no visual changes
### TEST PLAN
more unit tests, but plan to look at logs after we push this live and see if the problem is fixed.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13488:
URL: https://github.com/apache/superset/pull/13488#issuecomment-791817894
# [Codecov](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=h1) Report
> Merging [#13488](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=desc) (dd51b14) into [master](https://codecov.io/gh/apache/superset/commit/b4ca39ceeba557d4a8dfaa219e62389716cf76e8?el=desc) (b4ca39c) will **decrease** coverage by `3.68%`.
> The diff coverage is `68.50%`.
[](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13488 +/- ##
==========================================
- Coverage 77.12% 73.44% -3.69%
==========================================
Files 894 605 -289
Lines 45672 21285 -24387
Branches 5492 5530 +38
==========================================
- Hits 35223 15632 -19591
+ Misses 10325 5525 -4800
- Partials 124 128 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.90% <55.78%> (-0.19%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.37% <57.26%> (+0.97%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.24% <0.00%> (-0.33%)` | :arrow_down: |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `76.00% <0.00%> (-1.03%)` | :arrow_down: |
| [...rc/common/components/Collapse/Collapse.stories.tsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL0NvbGxhcHNlLnN0b3JpZXMudHN4) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <ø> (ø)` | |
| [.../src/common/components/Tooltip/Tooltip.stories.tsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvVG9vbHRpcC5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [...et-frontend/src/components/Alert/Alert.stories.tsx](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWxlcnQvQWxlcnQuc3Rvcmllcy50c3g=) | `0.00% <ø> (ø)` | |
| ... and [432 more](https://codecov.io/gh/apache/superset/pull/13488/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=footer). Last update [b4ca39c...45291a7](https://codecov.io/gh/apache/superset/pull/13488?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13488:
URL: https://github.com/apache/superset/pull/13488#discussion_r595703539
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -404,7 +404,7 @@ export default class ResultSet extends React.PureComponent<
query.errorMessage &&
query.errorMessage.indexOf('session timed out') > 0
) {
- this.props.actions.runQuery(query, true);
+ this.props.actions.reRunQuery(query);
Review comment:
I'm hoping that was it! :) I haven't been able to prove it yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #13488:
URL: https://github.com/apache/superset/pull/13488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13488:
URL: https://github.com/apache/superset/pull/13488#discussion_r594665190
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -404,7 +404,7 @@ export default class ResultSet extends React.PureComponent<
query.errorMessage &&
query.errorMessage.indexOf('session timed out') > 0
) {
- this.props.actions.runQuery(query, true);
+ this.props.actions.reRunQuery(query);
Review comment:
Oh, this is why the query was re-run after 1 minute with the same ID! Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13488:
URL: https://github.com/apache/superset/pull/13488#issuecomment-791811003
Cypress test rerun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13488:
URL: https://github.com/apache/superset/pull/13488#issuecomment-791645578
@etr2460 FYI, you might have some insight into this as well. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho closed pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #13488:
URL: https://github.com/apache/superset/pull/13488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #13488: fix: allow option to generate new query
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13488:
URL: https://github.com/apache/superset/pull/13488#issuecomment-801415549
🏷 ready-to-merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org