You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "isapego (via GitHub)" <gi...@apache.org> on 2025/01/28 04:09:08 UTC
[PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]
isapego opened a new pull request, #5127:
URL: https://github.com/apache/ignite-3/pull/5127
https://issues.apache.org/jira/browse/IGNITE-24324
Re-name package to `pyignite-dbapi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego merged PR #5127:
URL: https://github.com/apache/ignite-3/pull/5127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #5127:
URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931877159
##########
modules/platforms/python/CMakeLists.txt:
##########
@@ -16,7 +16,7 @@
#
cmake_minimum_required(VERSION 3.18)
-project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CXX)
+project(pyignite_dbapi VERSION ${IGNITE_VERSION} LANGUAGES CXX)
Review Comment:
Good point, agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego commented on code in PR #5127:
URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931817087
##########
modules/platforms/python/CMakeLists.txt:
##########
@@ -16,7 +16,7 @@
#
cmake_minimum_required(VERSION 3.18)
-project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CXX)
+project(pyignite_dbapi VERSION ${IGNITE_VERSION} LANGUAGES CXX)
Review Comment:
Well, there is no `3` suffix in other packages (nuget, java client), so I decided against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #5127:
URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931633742
##########
modules/platforms/python/CMakeLists.txt:
##########
@@ -16,7 +16,7 @@
#
cmake_minimum_required(VERSION 3.18)
-project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CXX)
+project(pyignite_dbapi VERSION ${IGNITE_VERSION} LANGUAGES CXX)
Review Comment:
Should it be `pyignite3_dbapi`, and `pyignite3` later, to avoid confusion with Ignite 2.x packages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org