You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/01 16:39:45 UTC
[GitHub] [couchdb-erlfdb] vkatsuba commented on a change in pull request #29: Add a basic CI config for rebar3
vkatsuba commented on a change in pull request #29:
URL: https://github.com/apache/couchdb-erlfdb/pull/29#discussion_r740358501
##########
File path: .github/workflows/rebar.yml
##########
@@ -0,0 +1,77 @@
+name: Rebar3 CI
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+
+jobs:
+
+ build_on_debian:
+
+ runs-on: ubuntu-latest
+
+ container:
+ image: docker://kocolosk/erlfdb-ci:latest
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Compile
+ run: rebar3 compile
+ - name: EUnit tests
+ run: rebar3 eunit
+
+ # build_erlef:
+ # runs-on: ubuntu-latest
+
+ # steps:
+ # - name: Check out repository code
+ # uses: actions/checkout@v2
+ # with:
+ # persist-credentials: false
+ # submodules: recursive
+ # - name: Setup Erlang
+ # uses: ./.github/actions/setup-beam
+ # with:
+ # otp-version: '24'
+ # rebar3-version: '3.16'
+ # - name: Install FoundationDB
+ # env:
+ # FDB_VERSION: '6.2.29'
+ # run: |
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # - name: Compile
+ # run: rebar3 compile
+ # - name: EUnit tests
+ # run: rebar3 eunit
+
+ build_on_windows_erlef:
+ runs-on: windows-latest
+ env:
+ DEBUG: 1
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: Setup Erlang
+ uses: ./.github/actions/setup-beam
Review comment:
I suppose can used just `erlef/setup-beam@v1` instead of submodule.
##########
File path: .github/workflows/rebar.yml
##########
@@ -0,0 +1,77 @@
+name: Rebar3 CI
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+
+jobs:
+
+ build_on_debian:
+
+ runs-on: ubuntu-latest
+
+ container:
+ image: docker://kocolosk/erlfdb-ci:latest
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Compile
+ run: rebar3 compile
+ - name: EUnit tests
+ run: rebar3 eunit
+
+ # build_erlef:
+ # runs-on: ubuntu-latest
+
+ # steps:
+ # - name: Check out repository code
+ # uses: actions/checkout@v2
+ # with:
+ # persist-credentials: false
+ # submodules: recursive
+ # - name: Setup Erlang
+ # uses: ./.github/actions/setup-beam
+ # with:
+ # otp-version: '24'
+ # rebar3-version: '3.16'
+ # - name: Install FoundationDB
+ # env:
+ # FDB_VERSION: '6.2.29'
+ # run: |
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # - name: Compile
+ # run: rebar3 compile
+ # - name: EUnit tests
+ # run: rebar3 eunit
+
+ build_on_windows_erlef:
+ runs-on: windows-latest
+ env:
+ DEBUG: 1
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: Setup Erlang
+ uses: ./.github/actions/setup-beam
+ with:
+ otp-version: '24'
+ rebar3-version: '3.16'
Review comment:
Can be used rebar version `3.17.0`.
##########
File path: .github/workflows/rebar.yml
##########
@@ -0,0 +1,77 @@
+name: Rebar3 CI
+
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+
+jobs:
+
+ build_on_debian:
+
+ runs-on: ubuntu-latest
+
+ container:
+ image: docker://kocolosk/erlfdb-ci:latest
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Compile
+ run: rebar3 compile
+ - name: EUnit tests
+ run: rebar3 eunit
+
+ # build_erlef:
+ # runs-on: ubuntu-latest
+
+ # steps:
+ # - name: Check out repository code
+ # uses: actions/checkout@v2
+ # with:
+ # persist-credentials: false
+ # submodules: recursive
+ # - name: Setup Erlang
+ # uses: ./.github/actions/setup-beam
+ # with:
+ # otp-version: '24'
+ # rebar3-version: '3.16'
+ # - name: Install FoundationDB
+ # env:
+ # FDB_VERSION: '6.2.29'
+ # run: |
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+ # dpkg -i foundationdb-server_${FDB_VERSION}-1_amd64.deb
+ # - name: Compile
+ # run: rebar3 compile
+ # - name: EUnit tests
+ # run: rebar3 eunit
+
+ build_on_windows_erlef:
+ runs-on: windows-latest
+ env:
+ DEBUG: 1
+ steps:
+ - name: Check out repository code
+ uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: Setup Erlang
+ uses: ./.github/actions/setup-beam
+ with:
+ otp-version: '24'
+ rebar3-version: '3.16'
+ - name: Setup MSVC toolchain
+ uses: ./.github/actions/msvc-dev-cmd
Review comment:
```suggestion
uses: ilammy/msvc-dev-cmd@v1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org