You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/11/04 17:31:26 UTC

[GitHub] activemq-artemis pull request: ARTEMIS-298 IPv6 escape broken

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/235

    ARTEMIS-298 IPv6 escape broken

    Previously we were using a long regular expression to detect whether or not a
    given host was IPv6. However, this was brittle and hard to read. Since we are
    already shipping Google Guava in the distribution it made sense to use the
    Guava method com.google.common.net.InetAddresses#isInetAddress rather than
    the regular expression.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ipv6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit 4d54e43ddcf3055ea9e8f80469c27b16411b6972
Author: jbertram <jb...@apache.org>
Date:   2015-11-03T22:29:27Z

    ARTEMIS-298 IPv6 escape broken
    
    Previously we were using a long regular expression to detect whether or not a
    given host was IPv6. However, this was brittle and hard to read. Since we are
    already shipping Google Guava in the distribution it made sense to use the
    Guava method com.google.common.net.InetAddresses#isInetAddress rather than
    the regular expression.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-298 IPv6 escape broken

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Hornetq protocol support

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---