You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Kristian Köhler (JIRA)" <ji...@codehaus.org> on 2006/08/22 08:09:48 UTC

[jira] Created: (MECLIPSE-150) [with PATCH] Plugin generates invalid Eclipse project files when multiproject contains two references to the same artifact

[with PATCH] Plugin generates invalid Eclipse project files when multiproject contains two references to the same artifact
--------------------------------------------------------------------------------------------------------------------------

                 Key: MECLIPSE-150
                 URL: http://jira.codehaus.org/browse/MECLIPSE-150
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: dependency resolution, multiproject
    Affects Versions: 2.2
            Reporter: Kristian Köhler
         Attachments: dependency-patch.txt

HI

in same circumstances the eclipse-plugin will generate a Eclipse project file which contains two references to the same artifact/project which will cause Eclipse to fail loading the project. The attached patch is very small and solves this problem by managing the references within a java.util.Set and using equals() within the IdeDependency.java class.

Thanks

Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (MECLIPSE-150) [with PATCH] Plugin generates invalid Eclipse project files when multiproject contains two references to the same artifact

Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barrie Treloar closed MECLIPSE-150.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.6

IdeDependency is comparable and equals delegates to compare, hashCode() also defined.

AbstractIdeSupportMojo.doDependencyResolution() maintains a list of dependencies and code already guards against duplicates:

{code:java}
// no duplicate entries allowed. System paths can cause this problem.
if ( !dependencies.contains( dep ) )
{
  dependencies.add( dep );
}
{code}

This should resolve your problem.

> [with PATCH] Plugin generates invalid Eclipse project files when multiproject contains two references to the same artifact
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-150
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-150
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: Core : Dependencies resolution and build path, Core : Multi-projects
>    Affects Versions: 2.2
>            Reporter: Kristian Köhler
>             Fix For: 2.6
>
>         Attachments: dependency-patch.txt
>
>
> HI
> in same circumstances the eclipse-plugin will generate a Eclipse project file which contains two references to the same artifact/project which will cause Eclipse to fail loading the project. The attached patch is very small and solves this problem by managing the references within a java.util.Set and using equals() within the IdeDependency.java class.
> Thanks
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira